Re: [PATCH v2 4/4] gdb, gdbserver, gdbsupport: remove includes of early headers

[Simon Marchi <simon.marchi@efficios.com>]

On 3/26/24 7:59 AM, Pedro Alves wrote:
> On 2024-03-23 02:14, Simon Marchi wrote:
>> Now that defs.h, server.h and common-defs.h are included via the
>> `-include` option, it is no longer necessary for source files to include
>> it.  Remove all the inclusions of these files I could find.  Update the
>> generation scripts where relevant.
>>
> 
> I didn't try to apply the patch locally to confirm, but (given the previous patch) AFAICS
> this leaves behind at least the common-defs.h include in gdbreplay.cc, right?  Any others left behind? 

In this v2, it's true that this include in gdbreplay.cc was left behind.
In the subsequent version of the series, I think it should either become
`-include common-defs.h` or `-include server.h`.  I think that was the
only one.

> For any that need to be kept in place, it would be nice to see them called out in the commit log,
> and to add a comment above the left-behind #include explaining why it exists.

I don't think it will be needed to leave any #include behind.

Simon