From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id /8ruGM7iAmbW7RYAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 10:59:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=T3xC6iZj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4DE801E0C0; Tue, 26 Mar 2024 10:59:26 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 14DDD1E030 for ; Tue, 26 Mar 2024 10:59:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CB13385828B for ; Tue, 26 Mar 2024 14:59:23 +0000 (GMT) Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11021010.outbound.protection.outlook.com [52.101.189.10]) by sourceware.org (Postfix) with ESMTPS id EE65D3858408 for ; Tue, 26 Mar 2024 14:58:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE65D3858408 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE65D3858408 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.189.10 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711465135; cv=pass; b=exG0iNfEDJ+z5QY1ATA1Kc7w9zoW7Hao90GCYunvqv4iZmGPjQn5fcr6Ohfqp9umA33kTbLYV8c4Q3OiceoT6mvMr5ZSMIcCKCDEspw9e/X5o43LjY0iOXCK4SEUmuXRJoG/tALPB5Pih/FRcybrHtp063Vi2K+SgAlcVB0hqEw= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711465135; c=relaxed/simple; bh=q0H6/xWqKIWrxQ4U3e5m5BvBUGAo8n1TtKoUnViN8ag=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=RAgmuTd2SN0sljtxxbofKrKspezcMWldYJq2g7NBDPwXD0X0IvGh53gQQDyb2w/2RIBnfJ4WFtlfamwrKI59+WUrt0/CmrveYZxJ0nLWA3NSibs/gLNIdDN2CZX1NuYGDjuEtRS27o8FxP10Uzp3wx9LvOlIk5UCVsDpu/96Urg= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=avBS0CDJtOePdlenmaOBRDSTQWVkDm6/Dq3HIaOnsQHzTO4EaCnjhzVc330/ak/nIM2J7WQDg8bFz9iWgvxP/I1delkPal6FtB47/Vmfa5J8wWiHTtx1wzg0YkiG6tOmwb0RZjJMpBWFrsVg0Q6beq+KDQ5mUTUPAim5OqqPhQp1Ovwn2BLnCuJCUH4arObTOGvSbI+bC9ctJSTaNojIMnNDyowy3vb8IDrMCR6vl2DF40k4Z8RqU4ksom8vfieX7V1HEyJ6CLl7AoBc2zeeYTk1+bvlrlBB5YNqWBCxph2kqfALd2F50aiFPIGbnJSiXRccEg9fD+lkS9HeF1nHhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2AJZTrdjxv2hEHxAZ4s51KBgL7y8X5xNio39Mg83NS0=; b=Hqn5r22T52Ico8fqgu8ocyEdVpYVbB+iiShYkhi6Z/PEX96yxDqbay4YrTQfihelUgG6+VLyoItnYcxv29MWJnKAy0jpoAnrSwIoGVKIEnXqJkwPvSbl4kOt3z/21snPeW4B2W9wFtlSvIgdCk84/KZAWGbks9bkchjjlWHJkkvfcYTKmZnJOI0CdkBNP55Xu4xebomlQLOyi5ZaRpvKfb0Zrj//zNBI5Nw1heypk1bC3nkIIYjc/BSUzhOFAlK40+u9D6rDmJ2guzWoPiobwFTITfx97aAGORj05qW8ih++rZyY3rvGfcle7NX98KQ5jT+DulaP47RnVH3fpyrT4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2AJZTrdjxv2hEHxAZ4s51KBgL7y8X5xNio39Mg83NS0=; b=T3xC6iZjvZrFdhbTaP8XPpkPFdPS7CYAW72Q6Zr99eO8xA9L+tor62d17I+pZPavljulV/trj44qhV2xBvhTTdDFsvfFHYCseh40T85hRrnDJ+y1m1FPFx+cIG7EPLVG+2BOBtHzviq7FrLYHd/I1mtmiWP7GJRdO/xoAsMGNudOONqNKzcNuxUAcfPTNEipTU9w7uW+wotTzlzHagMK6wk6Yz50q5yH447Gfqg/6lfhlQSLBFzb5rHl4YNhHE+VupvZ+ZkqlbNp/pKPt0Fej8dIxofs3tNVo75Tral+m8A8+cn+5ErUs5ekGHx9vGWEmHoM9gnhv5bMPYxhU6EuYQ== Received: from YT2PR01MB5525.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:50::8) by YT2PR01MB8888.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:bb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.33; Tue, 26 Mar 2024 14:58:50 +0000 Received: from YT2PR01MB5525.CANPRD01.PROD.OUTLOOK.COM ([fe80::beae:fb2f:8599:d9b2]) by YT2PR01MB5525.CANPRD01.PROD.OUTLOOK.COM ([fe80::beae:fb2f:8599:d9b2%4]) with mapi id 15.20.7409.031; Tue, 26 Mar 2024 14:58:49 +0000 Message-ID: Date: Tue, 26 Mar 2024 10:58:48 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] gdb, gdbserver, gdbsupport: remove includes of early headers To: Pedro Alves , gdb-patches@sourceware.org References: <20240323021648.154109-1-simon.marchi@efficios.com> <20240323021648.154109-5-simon.marchi@efficios.com> <0483600c-d703-400f-a341-f8b265fcbf18@palves.net> Content-Language: fr From: Simon Marchi In-Reply-To: <0483600c-d703-400f-a341-f8b265fcbf18@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0009.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00::22) To YT2PR01MB5525.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:50::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT2PR01MB5525:EE_|YT2PR01MB8888:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hWr+AligNNcw09DosYVH8vCS8SE1PTeU704u//0NLWBHUZ9OXLEL+VGGlZ9kzjTKf1BFJVow5lcFOHTFzqA3c7K8DIJIUP3RJiKraAKls8S9WdtWHMdTCWTeTX0OVPQNSSpAlNVcAV8SHre7/BWwBbJGyq1z9Lt1X8hw5Ubx4Djyn3F0f+u4grlZHWSLEzUHSnVO05uNy6OHn61b1SB2MgCo6nyY8042rC9krrF75YupxHTXA91G7Kx7L17s0qcmWztehJVf016EB6hCqFRqiTOsHnkcBsLgvf2ZyFEBhqD/OKY4VFEuH9f+gHERDCqWk03SkLy69mO0wsN0kZ1XJ16GnMqGveAxEtNMohkAlCHyf7Y/eOSvoTHinatuaXiqM7lifL3rkPxuzVrM0ecTm8VcvMv3Vh5dfuQD9SYOT9uIS2yzDEkbYYRXxzz6H4UNtqkCO8esXDGZCkRcLSQ1UiZnBd7SemIlK7bgdb4EfdrlxijdcFa6AtfNBtkbbKnqyfEba89iv4vBxi5KeN9lQTtRyEFq4729y+rVal4ReOM/M32IBd82euDNXTq4gYXuMFZf+AOcC/2gbq5LzqxB3y/cA49AEaPfr+4yPP+7AAyGS8C6AynWDmgcq2hau0tWeTGnl/SoT/oPANNJ3+rBgeJH3XBBiOVSfwOYUoW+KAw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT2PR01MB5525.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(366007)(376005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmZpOTkrcXo2Z05VVk5ZRFVjTmdTbEFmNFZXM1FieUFEWmo1N3Y2U0I2MGZR?= =?utf-8?B?YkoyeFB3TEhNcDRFL3RDcm9HYk9rRXVrVnZOK3ZlNVhVWTZHWllqRlFXZkZp?= =?utf-8?B?aEVQSWVpQVdONFlZV0hwUGJ3V040RTdKNkIvdmZzbVZLVFhXTG8vNmhQbmFs?= =?utf-8?B?YU9KZUpZaUJsWUpkdFIveGdZVFRkd0lIaWFVWFh6MS9rVHJkWEJBMm9QcVJu?= =?utf-8?B?TnZLSjJLejE1QkJySGlkbnAyaCt1cmNGbTlkR2NWUmY4T2VhcGRzck95Q0lG?= =?utf-8?B?S29GUVlxcmgydUNiQUJ6M0hPRk4zcXRkNVdWZlRucy9yZERwbkZBa2dOTk9Q?= =?utf-8?B?VUduY052Tm5qSS85TE05NHBxLzlpME5yK3JQRXFjTUxBVUhsZUFEM1d3R2hl?= =?utf-8?B?VUtMRkFmZHFuWFJqMXpZSUppZWV2MlpBeUR3NGQ4SXdoWjZ5Q0hRV3hWMEVG?= =?utf-8?B?ejFHckUvSDg5b0E1dzQvZkxYNE9Id0pPdVBoZVdtWis3WHliWkFFMnFJTEll?= =?utf-8?B?ZnlXL2Y3OWdnL09LQzYzVlVjQ2lKQ0szNkNvalRjc2RGb3lvcUUxU0g2eGNr?= =?utf-8?B?K25TV1JMQTFnaytXamZkbnFQeFZuOUk5OGFvb1BxVHdjQXhDRkxpYkdCWnJi?= =?utf-8?B?WXRLejd5UVJsZXJ4czZPQjVtSUJSMEFBZHhuRTcrbWhGVTFYQmpEWFI5WWZn?= =?utf-8?B?MGpVMXdyVVovQWE5ZEQ1Zzh1V21pRG1QaDlvTjRWK2h5N2xtU1I0WVlRYkwx?= =?utf-8?B?WmtCZVJ3djZMZEhwT3FTUTZwVkhMV1djWEVUd1BDNVRXd0h3UGNBaUpFQ0kw?= =?utf-8?B?WEVvVFFJTzYycnBiZjA3aExXV1hFc2RRS3N0UXBFTGV0M2VNakx1eWhKQWFC?= =?utf-8?B?SDFQSVNmTVBpVFQyREpYNEtJak1XSng5YytxY0hMQ2lubTdYL1JNV0JvVkg5?= =?utf-8?B?S3d1WE8xdUc4MHFTdW5mRkZEVnM4QmNROFRYNm1LRTgxaWh0RUpnWkltSW9j?= =?utf-8?B?Qjc2aktnM1lKV3JkbW5FaG4rVCtlWUo1OXFLQ1lGMHFXeDZNcit6TU95SDJ6?= =?utf-8?B?cFc3NzRNdXYrNU0wZlZEUzA2bkNEZElUMG9PT1J1YkVFVHFUR1BUbUJ3SXJj?= =?utf-8?B?NVZ4a3VuMy9wUVErTk8vb2NQM0duSjlORUJUNGdTcTYvek1OcW82aVREUC9S?= =?utf-8?B?KzNRV21HOURZY3VpalBUQ1lLU2JpSllQRWdmenFLbGlHaHpweWRqZHBCYzF1?= =?utf-8?B?cHlzVmlRTzk4L3I4L2FaS0VQTnNBcXB6UWpMOVVrUjJJVkpQallKWStXTFdB?= =?utf-8?B?U1pza1Y4Qm9zZGRWSGc4c05KSjNvNTJjbWVQanltdlJrMTlvWGtEQTJoazIw?= =?utf-8?B?aTkvTmgySUFCSHFhcDFoWE9pVnhlUkFuNU9KRGNYTGVWT1kzVWZUWmg1VytQ?= =?utf-8?B?UWZxNHJyME1nbHBvZVB3OXhmVWY2NllMWDJYYzVRbWFLbnRrSEVsN1pIYXE1?= =?utf-8?B?U2ZoYi9hMWxiZ3diWjU5M3FvV0Q3VDE1VnFGdXcrdnJ1a0pRYnA0UG84R0JP?= =?utf-8?B?MUpQWndrNDFveE42SyszTGM1OUVsV2FRN1JOcXJpZXIwVXZOOTFGbzNtd0lk?= =?utf-8?B?MXlVRWZycXdUMzdmcExMNUNDWW96VHhwYld1VVJXQm9NRVg0WnhueW92SmxH?= =?utf-8?B?T1k4cWYzcytpMm0xSjBVYlhYRUxLNlQ4ZXhyZWQ5cTVUWi9ETVRDZS9aVEVZ?= =?utf-8?B?c20wSWRaRkx3UVdqMkdFc3NaZGdNYkxyU1YzcmhwRFhtaVFVMm52M3ZDWUI0?= =?utf-8?B?MXRUWHJ6VFJHZXo3YWtqaDU0Zmk3N2R2MGZ4bjFoanV0UTNiaTBqQVJ1cG1P?= =?utf-8?B?c3JZNUdqUXB2TmhuRmdRS3FPNm5qN25VZ3RZNUtKalZTNTlkQVljdkVTVCsz?= =?utf-8?B?ZERtemtPQ0FWYjE1S2thMVZVSkpUZXRpa1ZLYzJKNm5kbnZRMTArL3NLYW5Y?= =?utf-8?B?SGR0bDNjVzZvN0E4MUVHT0pWNmtFY3hHaVQ1c0pLVkpnM1Evd3VoNlBaMFR6?= =?utf-8?B?Y2c1UEwvVXZRMkNvbG15ejIza1FJV01OejZTakFiYlRxVlVyc3piRlczY2gr?= =?utf-8?Q?PJWImLOxhuQAMZF41EsFToL8k?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a1c353c-b6dc-4b7d-b3a7-08dc4da53eab X-MS-Exchange-CrossTenant-AuthSource: YT2PR01MB5525.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Mar 2024 14:58:49.7375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1NH2Vlc339fWVnQt5lGeyBGzsmGkzmtWv76dQtjR3GC57i8nGerfEcK2nyP05eWIMwr6u54h+UT+cUpkBz7weA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB8888 X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/26/24 7:59 AM, Pedro Alves wrote: > On 2024-03-23 02:14, Simon Marchi wrote: >> Now that defs.h, server.h and common-defs.h are included via the >> `-include` option, it is no longer necessary for source files to include >> it. Remove all the inclusions of these files I could find. Update the >> generation scripts where relevant. >> > > I didn't try to apply the patch locally to confirm, but (given the previous patch) AFAICS > this leaves behind at least the common-defs.h include in gdbreplay.cc, right? Any others left behind? In this v2, it's true that this include in gdbreplay.cc was left behind. In the subsequent version of the series, I think it should either become `-include common-defs.h` or `-include server.h`. I think that was the only one. > For any that need to be kept in place, it would be nice to see them called out in the commit log, > and to add a comment above the left-behind #include explaining why it exists. I don't think it will be needed to leave any #include behind. Simon