From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 4/4] gdb, gdbserver, gdbsupport: remove includes of early headers
Date: Tue, 26 Mar 2024 11:59:16 +0000 [thread overview]
Message-ID: <0483600c-d703-400f-a341-f8b265fcbf18@palves.net> (raw)
In-Reply-To: <20240323021648.154109-5-simon.marchi@efficios.com>
On 2024-03-23 02:14, Simon Marchi wrote:
> Now that defs.h, server.h and common-defs.h are included via the
> `-include` option, it is no longer necessary for source files to include
> it. Remove all the inclusions of these files I could find. Update the
> generation scripts where relevant.
>
I didn't try to apply the patch locally to confirm, but (given the previous patch) AFAICS
this leaves behind at least the common-defs.h include in gdbreplay.cc, right? Any others left behind?
For any that need to be kept in place, it would be nice to see them called out in the commit log,
and to add a comment above the left-behind #include explaining why it exists.
next prev parent reply other threads:[~2024-03-26 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-23 2:14 [PATCH v2 0/4] Include early include files with `-include` Simon Marchi
2024-03-23 2:14 ` [PATCH v2 1/4] gdb, gdbserver, gdbsupport: reformat some Makefile variables, one entry per line Simon Marchi
2024-03-23 2:14 ` [PATCH v2 2/4] {gdb, gdbserver}/Makefile.in: remove unnecessary intermediary variables Simon Marchi
2024-03-23 2:14 ` [PATCH v2 3/4] gdb, gdbserver, gdbsupport: include early header files with `-include` Simon Marchi
2024-03-26 11:57 ` Pedro Alves
2024-03-26 14:39 ` Simon Marchi
2024-03-26 15:31 ` Pedro Alves
2024-03-26 15:49 ` Simon Marchi
2024-03-23 2:14 ` [PATCH v2 4/4] gdb, gdbserver, gdbsupport: remove includes of early headers Simon Marchi
2024-03-26 11:59 ` Pedro Alves [this message]
2024-03-26 14:58 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0483600c-d703-400f-a341-f8b265fcbf18@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox