From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id rrK9Kq24AmaIzBYAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 07:59:41 -0400 Received: by simark.ca (Postfix, from userid 112) id A00EC1E0C0; Tue, 26 Mar 2024 07:59:41 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8EEDE1E030 for ; Tue, 26 Mar 2024 07:59:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0E7F83858C36 for ; Tue, 26 Mar 2024 11:59:39 +0000 (GMT) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by sourceware.org (Postfix) with ESMTPS id 991733858D38 for ; Tue, 26 Mar 2024 11:59:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 991733858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 991733858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.208.170 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711454360; cv=none; b=ZtQ90gn8GBkm0eAR9Rp8ky9VqopVC5M5U8F4rON4mhPy+Kv8EfTuYFrBCNUm1NmEdJW3SaVeOiX+lZ8bux4KmH6pYrDYM9ku5huW7tuSQfKz2lyYYJNpHNiw5+Swub8e3sDe6HqQdEfY12kDybyIl9ntJ2/wRWu6HRrF6GdhCLs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711454360; c=relaxed/simple; bh=NboblHcH5BOdNchxCfLagydb8UTk5ZnqJwPUgRzRR1Q=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=CsKfpPTlEl1Akwly9YlIM3Q+vK7iPh07TmgOSIZR0rF2AKORPnGJ3lWpwt0mQHoKys9IBVMZaxo6rnqNPtJXn/fA0DcpfbCYhCz88sUPAqLZJR7QaAPmDwvD7pm6SXn8O8urxVl/p1rRHwrwRmafn4O3+XaG7coVCOGRyienmgs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2d4541bf57eso75424471fa.2 for ; Tue, 26 Mar 2024 04:59:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711454357; x=1712059157; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+4IvjOkHh/h+FEe41LRh0lIdtKKAOpiVFZk6iIfAsZ0=; b=has7ETFeieNHYlzizem7Gm/tG0oUPHXj1sqeChLFlRO75+9BE/t6FmFq2apmagaq6V tDKL1p1X9SOk7OPnRgtbea3ZlXY/jFiQ6vH2Nd4EcvGdFZ36np0tyPvn9ypM9+PTHavA +vlb/pIQ1EnnLGKLD7GFFU5UjNH57lp4AQ2oI+sJwzzaM6OnMLP3Ebd6hg2NULmk2AX4 m7B9I2dawppyGKWKuYAYrldJUQwrdVg0ZQ2Xfl787ua+1Wbp66V9E3LiQuORpK9N6Y5j UlUP3iMqlGx85UVl2K6+bT0ZFVZltZNI7a5SpOGOQ5z6XW+38Eu6bkGYxZEuBJ1FpLB3 eESQ== X-Forwarded-Encrypted: i=1; AJvYcCWTi9uY2YnYEHMQw/pho3dbKP0P4HxUcAHxPeYpUvNtI1Vv6ktE+FinljUCO5cXJZ0BRlcJEcxpeQWxH/wo0uVOhfiuCeEcrLtXrA== X-Gm-Message-State: AOJu0YwTgS5v6+HggOSA8kQDTxVR+SHGC7nXoWpRQfTiNM4HnbKYQ1rm /2lgbmygH4lRFO0+99ChOaiNSaT0KwZcsB66dx+Wi3zKxiv1/IaS/UhVvBuntfs= X-Google-Smtp-Source: AGHT+IHMcVwv5bMie+5Q1hQ9V8IH4Hc9MaNMcL1rnYDMpsaVRfZlQTMlih0aKL47mtFZ89FHQOT9tQ== X-Received: by 2002:a2e:a374:0:b0:2d2:e44e:a5cc with SMTP id i20-20020a2ea374000000b002d2e44ea5ccmr760753ljn.46.1711454356955; Tue, 26 Mar 2024 04:59:16 -0700 (PDT) Received: from ?IPV6:2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08? ([2001:8a0:f918:ab00:a3cb:34d8:f2e6:d08]) by smtp.gmail.com with ESMTPSA id bd14-20020a05600c1f0e00b004148bc72f7csm4213611wmb.4.2024.03.26.04.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 04:59:16 -0700 (PDT) Message-ID: <0483600c-d703-400f-a341-f8b265fcbf18@palves.net> Date: Tue, 26 Mar 2024 11:59:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] gdb, gdbserver, gdbsupport: remove includes of early headers Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org References: <20240323021648.154109-1-simon.marchi@efficios.com> <20240323021648.154109-5-simon.marchi@efficios.com> From: Pedro Alves In-Reply-To: <20240323021648.154109-5-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 2024-03-23 02:14, Simon Marchi wrote: > Now that defs.h, server.h and common-defs.h are included via the > `-include` option, it is no longer necessary for source files to include > it. Remove all the inclusions of these files I could find. Update the > generation scripts where relevant. > I didn't try to apply the patch locally to confirm, but (given the previous patch) AFAICS this leaves behind at least the common-defs.h include in gdbreplay.cc, right? Any others left behind? For any that need to be kept in place, it would be nice to see them called out in the commit log, and to add a comment above the left-behind #include explaining why it exists.