From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iKDxCLLuAmZO+RYAWB0awg (envelope-from ) for ; Tue, 26 Mar 2024 11:50:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711468210; bh=m1pxwN0hs51evBxzGIjAuEjg+XNQiJRyqTsFobgl87k=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oyoUoSs91Ncci8MNV5GkXnLWC6+5N2yceqMMlWSV16Mm200lX4Fvah0NYiZm/shvn 4dkXL/JFX7rWVWsg367XMsE96nAnoHgLHJu7TyR2ACrgh8TrJAslEf1+hBtJACRh2g ZWqEb/IB5yz97KljfhfDvBnAflKsnpBkjq9w6VHQ= Received: by simark.ca (Postfix, from userid 112) id 1F1EF1E0C0; Tue, 26 Mar 2024 11:50:10 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=kDS35rz2; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0B7251E030 for ; Tue, 26 Mar 2024 11:50:08 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9BEAC3858413 for ; Tue, 26 Mar 2024 15:50:07 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0CF803858413 for ; Tue, 26 Mar 2024 15:49:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CF803858413 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0CF803858413 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711468186; cv=none; b=jLAXnStEyiN2nsVf25INGiD//gnE6LUzQ09CckMHHJ5bfOVB3Yg7RIeU+GVVplelGb8du6UGn9nR7P6xUwoLeW02bhKrl2ZPiawpFN6dPsuvR6r7aSI/1U7GZUVrHnJTJZGn35jNsl4LF8yL1WbgVSQMEaIT/Nzvresz5qhBFfA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711468186; c=relaxed/simple; bh=m1pxwN0hs51evBxzGIjAuEjg+XNQiJRyqTsFobgl87k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=CEzlor2yDvPZNW/2IcidY6VFtoADjIZB5xP7TOLwJsYENN5i3Rw4UQgSR5XgFgT/aA0TIQTugXy5Ji4CKlkg31yn/C98dnOh5gqqZv+Enj7csiMh9f0eKbF3vffAtCbTmAmXak3zuTLjzfQzBtyhjGIl9Pfg8Sv7wuw3+zzS3Mo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711468184; bh=m1pxwN0hs51evBxzGIjAuEjg+XNQiJRyqTsFobgl87k=; h=Date:Subject:To:References:From:In-Reply-To:From; b=kDS35rz2lb4cu4iv43I8/VqVqLdikKd8Bo+YSo9mpHOaWLo5ZzURWa2t0qFjGz759 IsVxxbPYc80nT1YaTxKlOGTvm7bZnl0O3ArvaPb+2uetGCW7wC7BxGmFeo3JE38pX2 kSDCaiVb22EzC4vnSJpF2clMgF3nobLuelf+LEu0= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A372C1E030; Tue, 26 Mar 2024 11:49:44 -0400 (EDT) Message-ID: Date: Tue, 26 Mar 2024 11:49:44 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] gdb, gdbserver, gdbsupport: include early header files with `-include` To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20240323021648.154109-1-simon.marchi@efficios.com> <20240323021648.154109-4-simon.marchi@efficios.com> <80ffa3c0-7049-4b11-8c28-1a6b6ac5c0d7@palves.net> Content-Language: fr From: Simon Marchi In-Reply-To: <80ffa3c0-7049-4b11-8c28-1a6b6ac5c0d7@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/26/24 11:31 AM, Pedro Alves wrote: > You said a lot of different things, so I'm not sure which part I'd be agreeing with. :-) Sorry about that. > gdbreplay is a separate program that happens share a few bits of code with gdbserver, but > not that much. It currently includes common-defs.h at the top of its source file. > So I think the really simplest is to make the rule for gdbreplay.o you were > adding use "-include common-defs.h". Or add a new gdbreplay.h header that includes > common-defs.h and -include that one. > > Anything else than that seems like a distraction at this point, and I wouldn't call those > other options simpler. The look certainly more debatable to me. Ok, I'll keep the special rule for gdbreplay.o and make it -include common-defs.h. It's a bit weird because gdbreplay is made of gdbreplay.o, utils.o and version.o. The former includes common-defs.h, while the last two include server.h. But it works like that today, and I don't need to change it. Simon