From: Tom de Vries <tdevries@suse.de>
To: Alan Hayward <Alan.Hayward@arm.com>, Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 1/2] AArch64 AAPCS: Empty structs have non zero size in C++
Date: Thu, 10 Oct 2019 23:49:00 -0000 [thread overview]
Message-ID: <ce7d934a-4305-b28c-655d-1c545ffbfdcb@suse.de> (raw)
In-Reply-To: <018D8C19-1A45-4012-BAC6-90ACDA074740@arm.com>
On 21-01-2019 16:52, Alan Hayward wrote:
> + if { ( $lang == "c++"
> + && ( ( [regexp "struct_01_0(1|2|3)" $name match] && [regexp "^types-(td($|-)|tl(|l)(|-tf|-td|-tld)$)" $types match] )
> + || ( $name == "struct_01_02" && $types == "types-tfc" )
> + || ( $name == "struct_01_04" && [regexp "^types-(tf($|-)|ti(|-tf|-td|-tld)$)" $types match] )
> + || ( $name == "struct_02_01" && [regexp "^types-tf-t(c|s|i)" $types match] ) ) ) } {
> + setup_xfail gdb/24104 "x86_64-*-linux*"
> + }
> gdb_test "p/d check_arg_${name} (ref_val_${name})" "= 1"
> + if { ($lang == "c++" && $name == "struct_02_01" && [regexp "^types-(tf-t(c|s|i)|t(c|s|i)-tf)" $types match] ) } {
> + setup_xfail gdb/24104 "x86_64-*-linux*"
> + }
> gdb_assert [string eq ${answer} ${refval}] ${test}
These should have been kfails, not xfails.
Thanks,
- Tom
next prev parent reply other threads:[~2019-10-10 23:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 15:57 [PATCH 0/2] AArch64 AAPCS: Improve argument passing Alan Hayward
2019-01-16 15:57 ` [PATCH 1/2] AArch64 AAPCS: Empty structs have non zero size in C++ Alan Hayward
2019-01-17 17:08 ` Pedro Alves
2019-01-18 10:34 ` Alan Hayward
2019-01-21 15:52 ` Alan Hayward
2019-10-10 23:49 ` Tom de Vries [this message]
2019-10-11 12:14 ` [gdb/tdep] Fix 'Unexpected register class' assert in amd64_push_arguments Tom de Vries
2019-10-14 13:10 ` Alan Hayward
2019-10-14 15:23 ` Tom de Vries
2019-01-16 15:57 ` [PATCH 2/2] AArch64 AAPCS: Ignore static members Alan Hayward
2019-01-17 17:22 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce7d934a-4305-b28c-655d-1c545ffbfdcb@suse.de \
--to=tdevries@suse.de \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox