Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Hayward <Alan.Hayward@arm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: nd <nd@arm.com>, Alan Hayward <Alan.Hayward@arm.com>
Subject: [PATCH 0/2] AArch64 AAPCS: Improve argument passing
Date: Wed, 16 Jan 2019 15:57:00 -0000	[thread overview]
Message-ID: <20190116155734.53824-1-alan.hayward@arm.com> (raw)

This series improves the AAPCS argument passing on AArch64 (where small
structures are passed via float registers instead of on the stack).

The first patch ensures empty structures in C++ are dealt with correctly.
The second deals with static struct members.

It replaces the patch
"AArch64: Prevent infinite recursion when checking AAPCS types",
as the test failure is covered by the above. However that patch may still
be required in the future if I can craft a valid test case for it.

This patch adds a new test and expands an exisiting test. When run on
x86_64, many of the new test cases fail with:
amd64-tdep.c:958: internal-error: CORE_ADDR amd64_push_arguments(regcache*,
int, value**, CORE_ADDR, function_call_return_method): Assertion
`!"Unexpected register class."' failed
I had a look, but I don't know enough about the x86 argument passing.

Alan.


Alan Hayward (2):
  AArch64 AAPCS: Empty structs have non zero size in C++
  AArch64 AAPCS: Ignore static members

 gdb/aarch64-tdep.c                            |  16 ++
 .../gdb.base/infcall-nested-structs.exp       |  42 +++-
 .../gdb.cp/infcall-nested-static-structs.cc   | 222 ++++++++++++++++++
 .../gdb.cp/infcall-nested-static-structs.exp  | 173 ++++++++++++++
 4 files changed, 441 insertions(+), 12 deletions(-)
 create mode 100644 gdb/testsuite/gdb.cp/infcall-nested-static-structs.cc
 create mode 100644 gdb/testsuite/gdb.cp/infcall-nested-static-structs.exp

-- 
2.17.2 (Apple Git-113)


             reply	other threads:[~2019-01-16 15:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 15:57 Alan Hayward [this message]
2019-01-16 15:57 ` [PATCH 2/2] AArch64 AAPCS: Ignore static members Alan Hayward
2019-01-17 17:22   ` Pedro Alves
2019-01-16 15:57 ` [PATCH 1/2] AArch64 AAPCS: Empty structs have non zero size in C++ Alan Hayward
2019-01-17 17:08   ` Pedro Alves
2019-01-18 10:34     ` Alan Hayward
2019-01-21 15:52       ` Alan Hayward
2019-10-10 23:49         ` Tom de Vries
2019-10-11 12:14           ` [gdb/tdep] Fix 'Unexpected register class' assert in amd64_push_arguments Tom de Vries
2019-10-14 13:10             ` Alan Hayward
2019-10-14 15:23               ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190116155734.53824-1-alan.hayward@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox