Re: [PATCH 2/2] AArch64 AAPCS: Ignore static members

[Pedro Alves <palves@redhat.com>]

On 01/16/2019 03:57 PM, Alan Hayward wrote:
> Static members in C++ structs are global data and therefore not part of the
> list of struct members considered for passing in registers.
> 
> Note the corresponding code in GCC (from which the GDB AAPCS code is based)
> does not have any static member checks due to the static members not being
> part of the struct type at that point.
> 
> Add a new test based on gdb.base/infcall-nested-structs.exp, adding static
> members.

Diffing the files, it seems a lot is shared.  Would it be
possible and make sense to put the static members tests in
infcall-nested-structs.c, wrapped with #ifdef __cplusplus?

> diff --git a/gdb/testsuite/gdb.cp/infcall-nested-static-structs.cc b/gdb/testsuite/gdb.cp/infcall-nested-static-structs.cc
> new file mode 100644
> index 0000000000..bec63728f4
> --- /dev/null
> +++ b/gdb/testsuite/gdb.cp/infcall-nested-static-structs.cc
> @@ -0,0 +1,222 @@
> +/* This testcase is part of GDB, the GNU debugger.
> +
> +   Copyright 2018 Free Software Foundation, Inc.

This would be 2018-2019.

> +
> +/* Structures with two fields nested to various depths, one of which is static,
> +   along with some empty structures.  */

Is the "along with some empty structures." part important for this test?
Kind of seems like the other bug bleeds into this test?

> +
> +int cmp_struct_02_01 (struct struct_02_01 a,
> +			     struct struct_02_01 b)
> +{ return a.s2.s1.a == b.s2.s1.a && a.s2.s1.b == a.s2.s1.b; }
> +
> +int cmp_struct_02_02 (struct struct_02_02 a,
> +			     struct struct_02_02 b)
> +{ return a.a == b.a && a.b == b.b; }
> +
> +int cmp_struct_02_03 (struct struct_02_03 a,
> +			     struct struct_02_03 b)
> +{ return a.s4.s3.a == b.s4.s3.a && a.s6.s5.b == b.s6.s5.b; }
> +
> +int cmp_struct_02_04 (struct struct_02_04 a,
> +			     struct struct_02_04 b)
> +{ return a.a == b.a && a.b == b.b; }
> +

While diffing I noticed formatting changes spurious here.

> +foreach ta $int_types {
> +    start_gdb_and_run_tests $ta
> +}
> +
> +# if [support_complex_tests] {
> +#     foreach ta $complex_types {
> +# 	start_gdb_and_run_tests $ta
> +#     }
> +# }
> +

Looks like you meant to remove this.

Thanks,
Pedro Alves