From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159457-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 38136 invoked by alias); 10 Oct 2019 23:49:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 38128 invoked by uid 89); 10 Oct 2019 23:49:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-12.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HTo:U*palves
X-HELO: mx1.suse.de
Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2019 23:49:24 +0000
Received: from relay2.suse.de (unknown [195.135.220.254])	by mx1.suse.de (Postfix) with ESMTP id 5A725ACC9;	Thu, 10 Oct 2019 23:49:22 +0000 (UTC)
Subject: Re: [PATCH 1/2] AArch64 AAPCS: Empty structs have non zero size in C++
To: Alan Hayward <Alan.Hayward@arm.com>, Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, nd <nd@arm.com>
References: <20190116155734.53824-1-alan.hayward@arm.com> <20190116155734.53824-2-alan.hayward@arm.com> <386a4a7f-f7df-e1da-42b8-b0724e1e36b2@redhat.com> <5255A57D-0F2C-4A3B-816A-6F46C0B0C2B1@arm.com> <018D8C19-1A45-4012-BAC6-90ACDA074740@arm.com>
From: Tom de Vries <tdevries@suse.de>
Message-ID: <ce7d934a-4305-b28c-655d-1c545ffbfdcb@suse.de>
Date: Thu, 10 Oct 2019 23:49:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <018D8C19-1A45-4012-BAC6-90ACDA074740@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2019-10/txt/msg00289.txt.bz2

On 21-01-2019 16:52, Alan Hayward wrote:

> +       if { ( $lang == "c++"
> +              && ( ( [regexp "struct_01_0(1|2|3)" $name match] && [regexp "^types-(td($|-)|tl(|l)(|-tf|-td|-tld)$)" $types match] )
> +                   || ( $name == "struct_01_02" && $types == "types-tfc" )
> +                   || ( $name == "struct_01_04" && [regexp "^types-(tf($|-)|ti(|-tf|-td|-tld)$)" $types match] )
> +                   || ( $name == "struct_02_01" && [regexp "^types-tf-t(c|s|i)" $types match] ) ) ) } {
> +           setup_xfail gdb/24104 "x86_64-*-linux*"
> +       }
>         gdb_test "p/d check_arg_${name} (ref_val_${name})" "= 1"


> +           if { ($lang == "c++" && $name == "struct_02_01" && [regexp "^types-(tf-t(c|s|i)|t(c|s|i)-tf)" $types match] ) } {
> +               setup_xfail gdb/24104 "x86_64-*-linux*"
> +           }
>             gdb_assert [string eq ${answer} ${refval}] ${test}

These should have been kfails, not xfails.

Thanks,
- Tom