[PATCH] Fix build for gnu hurd

[PATCH] Fix build for gnu hurd

[Etienne Brateau]

695fd5ec1221707c9edda3fabd1a980808a30fe1 broke the build
---
 gdb/gnu-nat.c | 2 +-
 gdb/gnu-nat.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
index 985aa14debc..4999734b6d9 100644
--- a/gdb/gnu-nat.c
+++ b/gdb/gnu-nat.c
@@ -2617,7 +2617,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func)
 	  /* This region is distinct from the last one we saw, so report
 	     that previous one.  */
 	  if (last_protection != VM_PROT_NONE)
-	    (*func) (last_region_address,
+	    func (last_region_address,
 		     last_region_end - last_region_address,
 		     last_protection & VM_PROT_READ,
 		     last_protection & VM_PROT_WRITE,
diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h
index f4b3e3daec2..2ab06c8078e 100644
--- a/gdb/gnu-nat.h
+++ b/gdb/gnu-nat.h
@@ -130,7 +130,7 @@ struct gnu_nat_target : public inf_child_target
 					ULONGEST offset, ULONGEST len,
 					ULONGEST *xfered_len) override;
 
-  bool find_memory_regions (find_memory_region_ftype func, void *data)
+  bool find_memory_regions (find_memory_region_ftype func)
     override;
   void kill () override;
 
-- 
2.54.0

Re: [PATCH] Fix build for gnu hurd

[Tom de Vries]

On 6/8/26 6:01 PM, Etienne Brateau wrote:
> 695fd5ec1221707c9edda3fabd1a980808a30fe1 broke the build

Hi Etienne,

thanks for the patch, LGTM.

I'm not sure if you have a copyright assignment or not, but given that:
- you have no other contributions to this repository, and
- this is under the legally significant contribution threshold
I think it's ok regardless.

Approved-By: Tom de Vries <tdevries@suse.de>

Assuming you have no write permissions for the repo, I've pushed this, 
with a slightly more verbose commit message.

In case you don't have a copyright assignment for gdb, and are thinking 
about contributing more, please consider applying for one.

Thanks,
- Tom

> ---
>   gdb/gnu-nat.c | 2 +-
>   gdb/gnu-nat.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> index 985aa14debc..4999734b6d9 100644
> --- a/gdb/gnu-nat.c
> +++ b/gdb/gnu-nat.c
> @@ -2617,7 +2617,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func)
>   	  /* This region is distinct from the last one we saw, so report
>   	     that previous one.  */
>   	  if (last_protection != VM_PROT_NONE)
> -	    (*func) (last_region_address,
> +	    func (last_region_address,
>   		     last_region_end - last_region_address,
>   		     last_protection & VM_PROT_READ,
>   		     last_protection & VM_PROT_WRITE,
> diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h
> index f4b3e3daec2..2ab06c8078e 100644
> --- a/gdb/gnu-nat.h
> +++ b/gdb/gnu-nat.h
> @@ -130,7 +130,7 @@ struct gnu_nat_target : public inf_child_target
>   					ULONGEST offset, ULONGEST len,
>   					ULONGEST *xfered_len) override;
>   
> -  bool find_memory_regions (find_memory_region_ftype func, void *data)
> +  bool find_memory_regions (find_memory_region_ftype func)
>       override;
>     void kill () override;
>