From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZiuGOX/RJ2oLeT0AWB0awg (envelope-from ) for ; Tue, 09 Jun 2026 04:40:31 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vzvsgBhC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hy2xBV5+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vzvsgBhC; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hy2xBV5+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D4EC41E024; Tue, 09 Jun 2026 04:40:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B518C1E024 for ; Tue, 09 Jun 2026 04:40:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE0934B7A1F0 for ; Tue, 9 Jun 2026 08:40:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE0934B7A1F0 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vzvsgBhC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hy2xBV5+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vzvsgBhC; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hy2xBV5+ Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 8FE6C4BA2E0A for ; Tue, 9 Jun 2026 08:39:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8FE6C4BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8FE6C4BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780994367; cv=none; b=Xx6WQGP1xMl4h5YbOHCkiG4qobrPM79CcMGOXWrXYvpX6WKHUAXLVcT8UoMeJBwDF9A5cQ0GLOJK/NUDs1PwbtdHkn8Yjh3d6jS53ruayRAy37FnOJASFJRLeN4+5SSjeAeN5F9MiRi3Iqu8jxq/gz9Ht3qRFUcTD5Yn8deIFlI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780994367; c=relaxed/simple; bh=A7ToA8+WyyI1LqOYYPVOmns8sPy3cMW7GHGEfpS8PNI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=F4y2RS1q/zpBVejYKwLT5MgHvA+wFeWNyo0Z/jHAWRKcA2VzcfCMWlpFIi8XlPON1l91CrZW9qtjtdAj8hXog0MY5b+d78bx9bpBwTiVe2/8kEPmO9CulWu63Lr1ae/ys1bllqtScxMBkyFmTdXMPnNFk0JV1Qy4lDAAmJx8dNY= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vzvsgBhC; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hy2xBV5+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=vzvsgBhC; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hy2xBV5+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FE6C4BA2E0A Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 926366A81D; Tue, 9 Jun 2026 08:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780994366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pEDHRR/xnNcBpTbkUw8xm9uOLNsuFxvVgTq+mIfcjVI=; b=vzvsgBhCRLfGQMHlDWDtmfzukSMahLu0GzYdt7QQ1l1T1LlRCnIG8TT11jVjg1owQUuiob ncMrfzGZCKjX4PnXSmP8tEM9tXTD1k1ZAADFCOIMtam+b/YdP+L5wNQNJEaFvVcYGABwWi N78k8NlXJefrdpC7OrSTxMybgj3r2a0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780994366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pEDHRR/xnNcBpTbkUw8xm9uOLNsuFxvVgTq+mIfcjVI=; b=hy2xBV5+nCn12Pefw1xbPiu0QlAOWGuNU3KktfJ1FKRCnAQhDEo5Bpf/2qsogMr5q4N3tn uqJL1rOj0HWnniDw== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780994366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pEDHRR/xnNcBpTbkUw8xm9uOLNsuFxvVgTq+mIfcjVI=; b=vzvsgBhCRLfGQMHlDWDtmfzukSMahLu0GzYdt7QQ1l1T1LlRCnIG8TT11jVjg1owQUuiob ncMrfzGZCKjX4PnXSmP8tEM9tXTD1k1ZAADFCOIMtam+b/YdP+L5wNQNJEaFvVcYGABwWi N78k8NlXJefrdpC7OrSTxMybgj3r2a0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780994366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pEDHRR/xnNcBpTbkUw8xm9uOLNsuFxvVgTq+mIfcjVI=; b=hy2xBV5+nCn12Pefw1xbPiu0QlAOWGuNU3KktfJ1FKRCnAQhDEo5Bpf/2qsogMr5q4N3tn uqJL1rOj0HWnniDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7DFF5779A7; Tue, 9 Jun 2026 08:39:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KDqHHT7RJ2qgbQAAD6G6ig (envelope-from ); Tue, 09 Jun 2026 08:39:26 +0000 Message-ID: Date: Tue, 9 Jun 2026 10:39:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix build for gnu hurd To: Etienne Brateau , gdb-patches@sourceware.org References: <20260608160128.289752-1-etienne.brateau@gmail.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260608160128.289752-1-etienne.brateau@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; URIBL_BLOCKED(0.00)[suse.de:email,suse.de:mid,imap1.dmz-prg2.suse.org:helo]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_TO(0.00)[gmail.com,sourceware.org]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TAGGED_RCPT(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/8/26 6:01 PM, Etienne Brateau wrote: > 695fd5ec1221707c9edda3fabd1a980808a30fe1 broke the build Hi Etienne, thanks for the patch, LGTM. I'm not sure if you have a copyright assignment or not, but given that: - you have no other contributions to this repository, and - this is under the legally significant contribution threshold I think it's ok regardless. Approved-By: Tom de Vries Assuming you have no write permissions for the repo, I've pushed this, with a slightly more verbose commit message. In case you don't have a copyright assignment for gdb, and are thinking about contributing more, please consider applying for one. Thanks, - Tom > --- > gdb/gnu-nat.c | 2 +- > gdb/gnu-nat.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > index 985aa14debc..4999734b6d9 100644 > --- a/gdb/gnu-nat.c > +++ b/gdb/gnu-nat.c > @@ -2617,7 +2617,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func) > /* This region is distinct from the last one we saw, so report > that previous one. */ > if (last_protection != VM_PROT_NONE) > - (*func) (last_region_address, > + func (last_region_address, > last_region_end - last_region_address, > last_protection & VM_PROT_READ, > last_protection & VM_PROT_WRITE, > diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h > index f4b3e3daec2..2ab06c8078e 100644 > --- a/gdb/gnu-nat.h > +++ b/gdb/gnu-nat.h > @@ -130,7 +130,7 @@ struct gnu_nat_target : public inf_child_target > ULONGEST offset, ULONGEST len, > ULONGEST *xfered_len) override; > > - bool find_memory_regions (find_memory_region_ftype func, void *data) > + bool find_memory_regions (find_memory_region_ftype func) > override; > void kill () override; >