Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Etienne Brateau <etienne.brateau@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix build for gnu hurd
Date: Tue, 9 Jun 2026 10:39:26 +0200	[thread overview]
Message-ID: <ca3f4c12-8c99-4149-9665-2496abae2ef9@suse.de> (raw)
In-Reply-To: <20260608160128.289752-1-etienne.brateau@gmail.com>

On 6/8/26 6:01 PM, Etienne Brateau wrote:
> 695fd5ec1221707c9edda3fabd1a980808a30fe1 broke the build

Hi Etienne,

thanks for the patch, LGTM.

I'm not sure if you have a copyright assignment or not, but given that:
- you have no other contributions to this repository, and
- this is under the legally significant contribution threshold
I think it's ok regardless.

Approved-By: Tom de Vries <tdevries@suse.de>

Assuming you have no write permissions for the repo, I've pushed this, 
with a slightly more verbose commit message.

In case you don't have a copyright assignment for gdb, and are thinking 
about contributing more, please consider applying for one.

Thanks,
- Tom

> ---
>   gdb/gnu-nat.c | 2 +-
>   gdb/gnu-nat.h | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c
> index 985aa14debc..4999734b6d9 100644
> --- a/gdb/gnu-nat.c
> +++ b/gdb/gnu-nat.c
> @@ -2617,7 +2617,7 @@ gnu_nat_target::find_memory_regions (find_memory_region_ftype func)
>   	  /* This region is distinct from the last one we saw, so report
>   	     that previous one.  */
>   	  if (last_protection != VM_PROT_NONE)
> -	    (*func) (last_region_address,
> +	    func (last_region_address,
>   		     last_region_end - last_region_address,
>   		     last_protection & VM_PROT_READ,
>   		     last_protection & VM_PROT_WRITE,
> diff --git a/gdb/gnu-nat.h b/gdb/gnu-nat.h
> index f4b3e3daec2..2ab06c8078e 100644
> --- a/gdb/gnu-nat.h
> +++ b/gdb/gnu-nat.h
> @@ -130,7 +130,7 @@ struct gnu_nat_target : public inf_child_target
>   					ULONGEST offset, ULONGEST len,
>   					ULONGEST *xfered_len) override;
>   
> -  bool find_memory_regions (find_memory_region_ftype func, void *data)
> +  bool find_memory_regions (find_memory_region_ftype func)
>       override;
>     void kill () override;
>   


      reply	other threads:[~2026-06-09  8:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 16:01 Etienne Brateau
2026-06-09  8:39 ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca3f4c12-8c99-4149-9665-2496abae2ef9@suse.de \
    --to=tdevries@suse.de \
    --cc=etienne.brateau@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox