Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Use std::vector in lm_info_target
Date: Sun, 30 Apr 2017 00:42:00 -0000	[thread overview]
Message-ID: <c99f164341baa567c013551d2696fb3c@polymtl.ca> (raw)
In-Reply-To: <20170430003455.13878-1-simon.marchi@polymtl.ca>

On 2017-04-29 20:34, Simon Marchi wrote:
> v3 simply updates the patch to the changes made to lm_info_target 
> (previously
> lm_info).
> 
> Replace the two VEC fields with std::vector.
> 
> gdb/ChangeLog:
> 
> 	* solib-target.c (struct lm_info): Add default constructor,
> 	delete copy constructor and operator=.
> 	<segment_bases, section_bases>: Change type to
> 	std::vector<CORE_ADDR>.
> 	(library_list_start_segment, library_list_start_section,
> 	library_list_start_library, library_list_end_library,
> 	solib_target_free_library_list, solib_target_free_so,
> 	solib_target_relocate_section_addresses): Adjust.

Err I forgot to update the ChangeLog, here it is:

    gdb/ChangeLog:

            * solib-target.c: Include <vector>
            (struct lm_info_target) <~lm_info_target>: Remove.
            <segment_bases, section_bases>: Change type to
            std::vector<CORE_ADDR>.
            (library_list_start_segment, library_list_start_section,
            library_list_end_library,
            solib_target_relocate_section_addresses): Adjust.

Is the ChangeLog format acceptable for the destructor?

Simon


  reply	other threads:[~2017-04-30  0:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-16 14:14 [PATCH 0/4] Remove VEC (CORE_ADDR) Simon Marchi
2017-04-16 14:14 ` [PATCH 3/4] Use std::vector in solib-target lm_info Simon Marchi
2017-04-18 20:18   ` Pedro Alves
2017-04-19  4:18     ` Simon Marchi
2017-04-19  4:30     ` [PATCH v2] " Simon Marchi
2017-04-30  0:35     ` [PATCH v3] Use std::vector in lm_info_target Simon Marchi
2017-04-30  0:42       ` Simon Marchi [this message]
2017-05-02 16:06         ` Pedro Alves
2017-05-02 16:12       ` Pedro Alves
2017-05-02 17:25         ` Simon Marchi
2017-05-02 17:37           ` Pedro Alves
2017-05-02 17:50             ` Simon Marchi
2017-04-16 14:14 ` [PATCH 4/4] Remove definition of VEC (CORE_ADDR) Simon Marchi
2017-04-18 20:18   ` Pedro Alves
2017-04-16 14:14 ` [PATCH 1/4] Change field separator in gdbarch.sh Simon Marchi
2017-04-18 20:17   ` Pedro Alves
2017-04-18 20:20   ` Pedro Alves
2017-04-19  4:03     ` Simon Marchi
2017-04-19 10:31       ` Pedro Alves
2017-04-16 14:15 ` [PATCH 2/4] Change return type of gdbarch_software_single_step to vector<CORE_ADDR> Simon Marchi
2017-04-18 20:17   ` Pedro Alves
2017-04-19  4:08     ` Simon Marchi
2017-04-19 10:32       ` Pedro Alves
2017-05-02 17:35 ` [PATCH 0/4] Remove VEC (CORE_ADDR) Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c99f164341baa567c013551d2696fb3c@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox