From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-138737-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 302 invoked by alias); 30 Apr 2017 00:42:41 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 131059 invoked by uid 89); 30 Apr 2017 00:42:41 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 30 Apr 2017 00:42:39 +0000
Received: by simark.ca (Postfix, from userid 33)	id 3B3E11E4C1; Sat, 29 Apr 2017 20:42:40 -0400 (EDT)
To: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Use std::vector in lm_info_target
X-PHP-Originating-Script: 33:rcube.php
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Date: Sun, 30 Apr 2017 00:42:00 -0000
From: Simon Marchi <simon.marchi@polymtl.ca>
In-Reply-To: <20170430003455.13878-1-simon.marchi@polymtl.ca>
References: <614e9e92-fa8b-35f3-c15c-9dde043962e8@redhat.com> <20170430003455.13878-1-simon.marchi@polymtl.ca>
Message-ID: <c99f164341baa567c013551d2696fb3c@polymtl.ca>
X-Sender: simon.marchi@polymtl.ca
User-Agent: Roundcube Webmail/1.2.5
X-IsSubscribed: yes
X-SW-Source: 2017-04/txt/msg00821.txt.bz2

On 2017-04-29 20:34, Simon Marchi wrote:
> v3 simply updates the patch to the changes made to lm_info_target 
> (previously
> lm_info).
> 
> Replace the two VEC fields with std::vector.
> 
> gdb/ChangeLog:
> 
> 	* solib-target.c (struct lm_info): Add default constructor,
> 	delete copy constructor and operator=.
> 	<segment_bases, section_bases>: Change type to
> 	std::vector<CORE_ADDR>.
> 	(library_list_start_segment, library_list_start_section,
> 	library_list_start_library, library_list_end_library,
> 	solib_target_free_library_list, solib_target_free_so,
> 	solib_target_relocate_section_addresses): Adjust.

Err I forgot to update the ChangeLog, here it is:

    gdb/ChangeLog:

            * solib-target.c: Include <vector>
            (struct lm_info_target) <~lm_info_target>: Remove.
            <segment_bases, section_bases>: Change type to
            std::vector<CORE_ADDR>.
            (library_list_start_segment, library_list_start_section,
            library_list_end_library,
            solib_target_relocate_section_addresses): Adjust.

Is the ChangeLog format acceptable for the destructor?

Simon