From: Pedro Alves <palves@redhat.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Use std::vector in lm_info_target
Date: Tue, 02 May 2017 17:37:00 -0000 [thread overview]
Message-ID: <8c28e9b3-502d-bdf2-c129-ee58b7e99056@redhat.com> (raw)
In-Reply-To: <378fb30427fbc719605c1761450d6a51@polymtl.ca>
On 05/02/2017 06:25 PM, Simon Marchi wrote:
> On 2017-05-02 12:12, Pedro Alves wrote:
>> On 04/30/2017 01:34 AM, Simon Marchi wrote:
>>
>>> @@ -372,10 +364,7 @@ Could not relocate shared library \"%s\": wrong
>>> number of ALLOC sections"),
>>> {
>>> int bases_index = 0;
>>> int found_range = 0;
>>> - CORE_ADDR *section_bases;
>>> -
>>> - section_bases = VEC_address (CORE_ADDR,
>>> - li->section_bases);
>>> + CORE_ADDR *section_bases = li->section_bases.data ();
>>
>> I think this variable could be eliminated, and replaced by further
>> below doing:
>>
>> - low = section_bases[i];
>> + low = li->section_bases[i];
>>
>> in a couple places.
>>
>> Otherwise LGTM.
>
> Indeed, I changed it. Thanks.
>
Thanks. (There's a similar case in the segment_bases path, but
you probably saw it.)
--
Pedro Alves
next prev parent reply other threads:[~2017-05-02 17:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 14:14 [PATCH 0/4] Remove VEC (CORE_ADDR) Simon Marchi
2017-04-16 14:14 ` [PATCH 1/4] Change field separator in gdbarch.sh Simon Marchi
2017-04-18 20:17 ` Pedro Alves
2017-04-18 20:20 ` Pedro Alves
2017-04-19 4:03 ` Simon Marchi
2017-04-19 10:31 ` Pedro Alves
2017-04-16 14:14 ` [PATCH 3/4] Use std::vector in solib-target lm_info Simon Marchi
2017-04-18 20:18 ` Pedro Alves
2017-04-19 4:18 ` Simon Marchi
2017-04-19 4:30 ` [PATCH v2] " Simon Marchi
2017-04-30 0:35 ` [PATCH v3] Use std::vector in lm_info_target Simon Marchi
2017-04-30 0:42 ` Simon Marchi
2017-05-02 16:06 ` Pedro Alves
2017-05-02 16:12 ` Pedro Alves
2017-05-02 17:25 ` Simon Marchi
2017-05-02 17:37 ` Pedro Alves [this message]
2017-05-02 17:50 ` Simon Marchi
2017-04-16 14:14 ` [PATCH 4/4] Remove definition of VEC (CORE_ADDR) Simon Marchi
2017-04-18 20:18 ` Pedro Alves
2017-04-16 14:15 ` [PATCH 2/4] Change return type of gdbarch_software_single_step to vector<CORE_ADDR> Simon Marchi
2017-04-18 20:17 ` Pedro Alves
2017-04-19 4:08 ` Simon Marchi
2017-04-19 10:32 ` Pedro Alves
2017-05-02 17:35 ` [PATCH 0/4] Remove VEC (CORE_ADDR) Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c28e9b3-502d-bdf2-c129-ee58b7e99056@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox