From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102833 invoked by alias); 2 May 2017 17:37:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102732 invoked by uid 89); 2 May 2017 17:37:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f174.google.com Received: from mail-wr0-f174.google.com (HELO mail-wr0-f174.google.com) (209.85.128.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 02 May 2017 17:37:49 +0000 Received: by mail-wr0-f174.google.com with SMTP id l50so87227617wrc.3 for ; Tue, 02 May 2017 10:37:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=KR4xkdBLJsRlPYXeddWVeCmDIUhI6qjsi+2kLWAN2uc=; b=F5P3NCNV12dHja4oZIx8nF5/HMC+q6OQkT0abjKGk8qPx4HEhjAsfzFymzQpyqr2W2 LCbnfwutfCIRTaFllWx5GHrNuPwDyX0y3snGn4QRUFAdyvQYbBQBMiZmA5O0+LeRsOT0 UxWCrM5XYwXY8ETmSB3IITnoPWTubdInyeeb/pU4fzOqFZsA2ZhIvZY3mj/cVCBRU2mF +WR2Zip9BTi7DnKcphXywfZ9MNhJ/eWzXgrYEh3J5AdDgGbLzq5fdphayoJIJW/iC7On uHKHBiK2GkhJwYmMwKp3vW8zcQR6XG/W/Uu7VgxluitktnpwPW9ghdQVXaVJ7RNHg47H yilQ== X-Gm-Message-State: AN3rC/5BNdujJOdl2As+4pUwPkHOOYqeL4/MsHXcV6QUVmNEBkNOMyV3 zczL1gEcUctYNABs X-Received: by 10.223.163.137 with SMTP id l9mr19380627wrb.128.1493746669758; Tue, 02 May 2017 10:37:49 -0700 (PDT) Received: from [192.168.0.102] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id p22sm1786065wmi.18.2017.05.02.10.37.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 May 2017 10:37:48 -0700 (PDT) Subject: Re: [PATCH v3] Use std::vector in lm_info_target To: Simon Marchi References: <614e9e92-fa8b-35f3-c15c-9dde043962e8@redhat.com> <20170430003455.13878-1-simon.marchi@polymtl.ca> <7652620c-1f87-8fe2-ee9a-50952166197e@redhat.com> <378fb30427fbc719605c1761450d6a51@polymtl.ca> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <8c28e9b3-502d-bdf2-c129-ee58b7e99056@redhat.com> Date: Tue, 02 May 2017 17:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <378fb30427fbc719605c1761450d6a51@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00022.txt.bz2 On 05/02/2017 06:25 PM, Simon Marchi wrote: > On 2017-05-02 12:12, Pedro Alves wrote: >> On 04/30/2017 01:34 AM, Simon Marchi wrote: >> >>> @@ -372,10 +364,7 @@ Could not relocate shared library \"%s\": wrong >>> number of ALLOC sections"), >>> { >>> int bases_index = 0; >>> int found_range = 0; >>> - CORE_ADDR *section_bases; >>> - >>> - section_bases = VEC_address (CORE_ADDR, >>> - li->section_bases); >>> + CORE_ADDR *section_bases = li->section_bases.data (); >> >> I think this variable could be eliminated, and replaced by further >> below doing: >> >> - low = section_bases[i]; >> + low = li->section_bases[i]; >> >> in a couple places. >> >> Otherwise LGTM. > > Indeed, I changed it. Thanks. > Thanks. (There's a similar case in the segment_bases path, but you probably saw it.) -- Pedro Alves