Re: [PATCH 1/6] sim: sh: rework register layout with anonymous unions & structs

[Luis Machado via Gdb-patches <gdb-patches@sourceware.org>]

On 11/11/21 7:32 PM, Luis Machado wrote:
> On 11/11/21 7:25 PM, Mike Frysinger wrote:
>> On 11 Nov 2021 09:41, Luis Machado wrote:
>>> I can't pinpoint the exact SH patch, but builds are broken for
>>> --enable-targets=all in Ubuntu 18.04 with GCC 7.5:
>>
>> pretty sure the warnings have always been there for you, we just turned
>> -Werror in more cases recently
>>
> 
> That's fine and I'm all for more -Werror. But builds should be able to 
> complete regardless, right?
> 
>>> binutils-gdb/sim/sh/interp.c: In function ‘ppi_insn’:
>>> ./ppi.c:875:21: error: assuming signed overflow does not occur when
>>> assuming that (X + c) < X is always false [-Werror=strict-overflow]
>>>            carry = res < Sy;
>>>                    ~~~~^~~~
>>> ./ppi.c:849:21: error: assuming signed overflow does not occur when
>>> assuming that (X - c) > X is always false [-Werror=strict-overflow]
>>>            carry = res > Sy;
>>>                    ~~~~^~~~
>>> ./ppi.c:823:21: error: assuming signed overflow does not occur when
>>> assuming that (X + c) < X is always false [-Werror=strict-overflow]
>>>            carry = res < Sx;
>>>                    ~~~~^~~~
>>> ./ppi.c:797:21: error: assuming signed overflow does not occur when
>>> assuming that (X - c) > X is always false [-Werror=strict-overflow]
>>>            carry = res > Sx;
>>>                    ~~~~^~~~
>>> binutils-gdb-arm64-bionic/sim/../../../repos/binutils-gdb/sim/sh/interp.c: 
>>>
>>> In function ‘sim_resume’:
>>> ./ppi.c:1178:28: warning: ‘res’ may be used uninitialized in this
>>> function [-Wmaybe-uninitialized]
>>>              MACL = DSP_R (z) = res;
>>> ./ppi.c:44:7: note: ‘res’ was declared here
>>>      int res, res_grd;
>>>          ^~~
>>
>> how exactly are you building things ?  we don't enable -Wstrict-overflow.
> 
> No special way. I just ./configure with --enable-targets=all and let it 
> run. I can bisect it or gather a bit more information if you think it 
> would be useful.
> 
> Worth mentioning that it doesn't run into such warnings/failures on 
> Ubuntu 20.04 with gcc 9.3.

If you don't have a handy setup on your end, please let me know and I 
can take a look at it, of course.