From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZPcOIJKbjWGcRgAAWB0awg (envelope-from ) for ; Thu, 11 Nov 2021 17:39:14 -0500 Received: by simark.ca (Postfix, from userid 112) id 71F261F0BD; Thu, 11 Nov 2021 17:39:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCBA71ECEB for ; Thu, 11 Nov 2021 17:39:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1C241385AC33 for ; Thu, 11 Nov 2021 22:39:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1C241385AC33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1636670353; bh=I73BBVFYDdG6MiCSEGNnm8QapKeiWh6uziOECJ+VaDU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=EXsO0yAZNLTDmYWYWRxp/pv0YblTYcBU0P9SAj1b+IzeO2EzIJbyY3Swch4fSSwfG +FpgUvv9UYdLnXOOYbTADYko/xEOB/BQFQ5XuEOhZ2CBtMBeVFsIpbEaxmTmG5s6mZ ItoB5LyFRcIvDflQh1MpQyM+JDh+7oDVHmOoqilQ= Received: from mail-vk1-xa29.google.com (mail-vk1-xa29.google.com [IPv6:2607:f8b0:4864:20::a29]) by sourceware.org (Postfix) with ESMTPS id ECCFB385840E for ; Thu, 11 Nov 2021 22:38:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ECCFB385840E Received: by mail-vk1-xa29.google.com with SMTP id k83so3273840vke.7 for ; Thu, 11 Nov 2021 14:38:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I73BBVFYDdG6MiCSEGNnm8QapKeiWh6uziOECJ+VaDU=; b=6O0S+rb6mf5r8Zyko5WisnBjb6kaneAE1snyx4lqJtbU/BdeWdkQFo+FlqQPd9Yn9c a6wmN8dGjo5/cWxEYOE9KBgcyPcS76vrjSon6/BRRlTblT1/a7lkJQ9Ettq1VV4TsM7R ol22WX8M84tNm6geJmIjv8zk72OYYrACQmv+eJ+u3BxeTdFlMGtqFDDWTR7zqBr3Nt4A AR4a9U4MgvrSDyv+dALzaC2a+8Ugv0vGIe5LraRyPDMQcYjwlSTNXUpLGhF+Ok1vdRtS DpYb8+uNN8vgTThslRyhtuBauqJkG40e9dJB4eqmzpGU8bIuR08abQt8iAfq37NLvgUT SjOA== X-Gm-Message-State: AOAM533mvgb8E3C4j9F4IWc7pQynTcpTor9rExI++R0vZyjS+1Lmp2Wj mAyVhI0URRtcZ5STxf3G345sMGswtaky9A== X-Google-Smtp-Source: ABdhPJwIoI3D/zz/ao0aBq1hBkxl1J+DlEUtUHZttVTOH8v5S7Ln7MEyY/rivz4q0ywrckYbIP1Hbg== X-Received: by 2002:a05:6122:920:: with SMTP id j32mr16603085vka.20.1636670333317; Thu, 11 Nov 2021 14:38:53 -0800 (PST) Received: from ?IPv6:2804:7f0:4841:487c:f853:f29d:cfe6:370b? ([2804:7f0:4841:487c:f853:f29d:cfe6:370b]) by smtp.gmail.com with ESMTPSA id m67sm2908882vsc.0.2021.11.11.14.38.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Nov 2021 14:38:52 -0800 (PST) Subject: Re: [PATCH 1/6] sim: sh: rework register layout with anonymous unions & structs To: gdb-patches@sourceware.org References: <20211107003254.4298-1-vapier@gentoo.org> <68a4c7ee-700a-22f5-62ad-9257de03e9f9@linaro.org> Message-ID: Date: Thu, 11 Nov 2021 19:38:50 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 11/11/21 7:32 PM, Luis Machado wrote: > On 11/11/21 7:25 PM, Mike Frysinger wrote: >> On 11 Nov 2021 09:41, Luis Machado wrote: >>> I can't pinpoint the exact SH patch, but builds are broken for >>> --enable-targets=all in Ubuntu 18.04 with GCC 7.5: >> >> pretty sure the warnings have always been there for you, we just turned >> -Werror in more cases recently >> > > That's fine and I'm all for more -Werror. But builds should be able to > complete regardless, right? > >>> binutils-gdb/sim/sh/interp.c: In function ‘ppi_insn’: >>> ./ppi.c:875:21: error: assuming signed overflow does not occur when >>> assuming that (X + c) < X is always false [-Werror=strict-overflow] >>>            carry = res < Sy; >>>                    ~~~~^~~~ >>> ./ppi.c:849:21: error: assuming signed overflow does not occur when >>> assuming that (X - c) > X is always false [-Werror=strict-overflow] >>>            carry = res > Sy; >>>                    ~~~~^~~~ >>> ./ppi.c:823:21: error: assuming signed overflow does not occur when >>> assuming that (X + c) < X is always false [-Werror=strict-overflow] >>>            carry = res < Sx; >>>                    ~~~~^~~~ >>> ./ppi.c:797:21: error: assuming signed overflow does not occur when >>> assuming that (X - c) > X is always false [-Werror=strict-overflow] >>>            carry = res > Sx; >>>                    ~~~~^~~~ >>> binutils-gdb-arm64-bionic/sim/../../../repos/binutils-gdb/sim/sh/interp.c: >>> >>> In function ‘sim_resume’: >>> ./ppi.c:1178:28: warning: ‘res’ may be used uninitialized in this >>> function [-Wmaybe-uninitialized] >>>              MACL = DSP_R (z) = res; >>> ./ppi.c:44:7: note: ‘res’ was declared here >>>      int res, res_grd; >>>          ^~~ >> >> how exactly are you building things ?  we don't enable -Wstrict-overflow. > > No special way. I just ./configure with --enable-targets=all and let it > run. I can bisect it or gather a bit more information if you think it > would be useful. > > Worth mentioning that it doesn't run into such warnings/failures on > Ubuntu 20.04 with gcc 9.3. If you don't have a handy setup on your end, please let me know and I can take a look at it, of course.