Re: [PATCH 1/6] sim: sh: rework register layout with anonymous unions & structs

[Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>]

[-- Attachment #1: Type: text/plain, Size: 1586 bytes --]

On 11 Nov 2021 09:41, Luis Machado wrote:
> I can't pinpoint the exact SH patch, but builds are broken for 
> --enable-targets=all in Ubuntu 18.04 with GCC 7.5:

pretty sure the warnings have always been there for you, we just turned
-Werror in more cases recently

> binutils-gdb/sim/sh/interp.c: In function ‘ppi_insn’:
> ./ppi.c:875:21: error: assuming signed overflow does not occur when 
> assuming that (X + c) < X is always false [-Werror=strict-overflow]
>           carry = res < Sy;
>                   ~~~~^~~~
> ./ppi.c:849:21: error: assuming signed overflow does not occur when 
> assuming that (X - c) > X is always false [-Werror=strict-overflow]
>           carry = res > Sy;
>                   ~~~~^~~~
> ./ppi.c:823:21: error: assuming signed overflow does not occur when 
> assuming that (X + c) < X is always false [-Werror=strict-overflow]
>           carry = res < Sx;
>                   ~~~~^~~~
> ./ppi.c:797:21: error: assuming signed overflow does not occur when 
> assuming that (X - c) > X is always false [-Werror=strict-overflow]
>           carry = res > Sx;
>                   ~~~~^~~~
> binutils-gdb-arm64-bionic/sim/../../../repos/binutils-gdb/sim/sh/interp.c: 
> In function ‘sim_resume’:
> ./ppi.c:1178:28: warning: ‘res’ may be used uninitialized in this 
> function [-Wmaybe-uninitialized]
>             MACL = DSP_R (z) = res;
> ./ppi.c:44:7: note: ‘res’ was declared here
>     int res, res_grd;
>         ^~~

how exactly are you building things ?  we don't enable -Wstrict-overflow.
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]