Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix -trace-save crash when argument is missing
Date: Mon, 17 Oct 2016 20:37:00 -0000	[thread overview]
Message-ID: <c1933d89-e2bd-4d2d-698f-01db89408d9e@ericsson.com> (raw)
In-Reply-To: <CAH=s-PPCUQfNuyK-j8GiG6fbF1NN8Qhi2jUniwFxaQSgeL1TQg@mail.gmail.com>

On 16-10-17 04:08 PM, Yao Qi wrote:
> HI Simon,
> Patch is good to me.  A nit below,
> 
> On Fri, Oct 14, 2016 at 4:25 PM, Simon Marchi <simon.marchi@ericsson.com> wrote:
>> +
>> +  if (oind >= argc)
> 
> Nit:  if (argc - oind != 1)
> 
>> +    error (_("Argument required (file in which to save trace data)"));
>> +

Good idea, otherwise giving too many arguments still works, when it
shouldn't.  I'll change the error message to:

  "Exactly one argument required ..."

Thanks.


  reply	other threads:[~2016-10-17 20:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 20:26 Simon Marchi
2016-10-17 20:09 ` Yao Qi
2016-10-17 20:37   ` Simon Marchi [this message]
2016-10-17 20:50     ` Simon Marchi
2016-10-17 20:56       ` Simon Marchi
2016-10-17 20:59       ` Pedro Alves
2016-10-17 21:07         ` Simon Marchi
2016-10-17 21:08           ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1933d89-e2bd-4d2d-698f-01db89408d9e@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox