From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 65247 invoked by alias); 17 Oct 2016 20:37:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 65235 invoked by uid 89); 17 Oct 2016 20:37:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 spammy= X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 20:37:05 +0000 Received: from ESESSHC016.ericsson.se (Unknown_Domain [153.88.183.66]) by (Symantec Mail Security) with SMTP id 24.92.02458.E6635085; Mon, 17 Oct 2016 22:37:03 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.66) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Oct 2016 22:36:58 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.110.144] (192.75.88.130) by AMSPR07MB390.eurprd07.prod.outlook.com (10.242.22.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.5; Mon, 17 Oct 2016 20:36:57 +0000 Subject: Re: [PATCH] Fix -trace-save crash when argument is missing To: Yao Qi References: <20161014202536.21670-1-simon.marchi@ericsson.com> CC: "gdb-patches@sourceware.org" From: Simon Marchi Message-ID: Date: Mon, 17 Oct 2016 20:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BLUPR13CA0032.namprd13.prod.outlook.com (10.160.191.42) To AMSPR07MB390.eurprd07.prod.outlook.com (10.242.22.13) X-MS-Office365-Filtering-Correlation-Id: 01cd8446-ec3e-41e8-a4fd-08d3f6cd56e3 X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;2:UlQhh9q92BfW2nYtk9Rmc8+nxd0G6ol87qLADLMSJ1ZPFbzYApw5JrWFkgc0Z6c+xxHCDiKsarXt8J70e3JsAyLRJXxV3YgAQMCIb6TnjYmOZY7Ww/yZ+2h1J47gnOb1Z9/eSMvmA2IZ5Uofmdl3uXIvWgs0Yi8D89goqWngt22PQ76gdJqGAzkRtHRgDQ5//gJ0SPn81dUJSmG67uaZyg==;3:kwBIGyOwqGOMpf4e8+P1sMTh2IiR9t0Krt/Ur7vwC24NnGDSiKb4zaTUf7XGLrGDtV5dGTLC41y2LUSgZ5lcg6ypYsIENEaIiG57npAIWwbuNFiGNwdK1XA0zxMbf1QHeoxO+/FCCiu7CoCIYc+Iew== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB390; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;25:REOYESDjq5XNx+pTjYWI3AUmy6sUTboFF8/1ipm/DPTH4icdNPWTxADSOrT7oLwEQRx8rdYSnwn6MUdgbP+PhEYaeUEPjwqPi5fptW4VhpUanYjRmGTLU7GCHtuSMSurIJacqPUVUAvg2ydc94Y3uUaKgoQisKvoMT395MKqeFmPzPD1wNlkMFNWEHtxD25nrXr2iQZm2etrN8h9OiZRINvbe2EhjV+6IK57y759+5N1RP13+gVhU7qZTq0LiMK7SsoRWpUWU0UrZaXIUHWzKrbnu4GWgwMkOqihCPCpBGFE6As2QQMGxg3Gf/50OUqWxUb12/1rZiqG0XPWxYdRVKk7QZCc+7CcbphHPbKgP4JzBOVMGaxcgtdcHLMh3Rj3GnDuTQG/DzsYt3oYJcPiSVEeWipgmTHmjNnglnj7aDfka8IUsCXWlpuehdT0U9ucakU/l53cIWuiDtkAbd7ayfHGj+/G8yB09iDAbMb/x7nafXcErDwc43qKpYGTDxMISfJBwXDNhXEYNPUuZzlhsuIv6QhlqjE0C2LwVvboyo53z96kYzFq+9Jwj1gkOSW0Na/CdA4U2SqBQWXPAEBv5DXjKjtWJIQSzwD+Ek45wz2CrWekeE5uZe217Z7Y+QlNgiy0WG+I0QjuOw5kCI7obIlsh3BIw6izIqe+qPbV1Asi1xhzJ3lmRHleZwU8lAWPGDvuv4nwXUys9jueIMu19rePeQLHll3THRvCFiSIoMAGgsEIJLwSLhXvWva/O43w X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;31:e2k/Ero1J2Jdgb904e7KQVj+SAgpxV8AudZTbYLK0eUCWMtpycKvuGggr4kUyp8po12vIaAxCfpBBXsrAUusOWMi9kTjxsp7XinoShNzpAyJIBt6OjOCRtuBflSOitxGASNPNAtsQfppqll4OaaD09U4kJZH/8MR89aEgZ61o9SSUsV8e/3qmRz/WJpanEnY+x7r97BThFInhju1ar8t0TyI6eWPwbO1FVREE5zQLPMhTsjoNIz6ee3NT5s4bSpj+ejbE9iBiqcGEK0GveEmJg==;20:/lpNyBWQRNTdDh2G1lQZWoHsD7OT2YwQpDtvKzwwOarjUK75sgSdh/Zm/u7WzZw1G17wwyQL43o/moiOLppw3Ew1XkhJoNz6WwEENheaQqk9+wwFq2qtqfRSE3dPbA1RqnH99dZZCI54O7H3KIkweSpstNXwxOnXof3GV2CxwfEFxDe6PWKyYQH7vkzs7ruPqOwfjDBgixGIJbDWT+eMR7wE2WAjFgZYiVYrOaQkAo0Z32Yn6OO5GmgnLB6Axc5xantmWxmJK91jytPKtMb5xFcL/22NFdV4In2KsKX9PrD55r6TIsFMnL3Fr71oOqywrEl4u3VGMN4gVLHVbVxfjrhc9vNKJArfk2aXava50Av9sXDZoRS54hMZOY1pQv3S2iHuquWTmqN2K9UrC54DWR8rRt2J5ShF+tc2X7oVy+PfWI3cIeiQRHISzoSmpbzP8D8A07fozuDMcY79Fn7VHStDWmROYoU0npDU2YQ9avOXE8IcfKO9aHJNsR1dS7qS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:AMSPR07MB390;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB390; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;4:ni0+v+6bNKfufkL4CqxDuis9aeyNtdHtKTicdlUznUeWklOlzzEDPLSMvGweiKRRRZGHEjEPR6VLF05tnWQGIKXqpS3vt583VfwxCpSfv8R+7tRR3H3zimp1Wyc8ezMSt2ctjmJnYAMnvXmEqS9VGGuZ9ph5GyFU+rISY4EVtF8bvPvQiNzT3hg/I81zVR0R3wdfxdQzrx3SClmYQnFNOYmwT/CIJ+2V4HJCTCAjZOUsFC081EI2yq7G+kzIlHnRn+TZ0jW7yYwqVfmegAioc54KzhAuWN/FHiFp7SvL5orZ5JttETgoG5ZgayCip54aMvu7smunlxX5uQlqrLborzJ2+9TRglOMVItUqsXGdbjd7P61tht5eBOSUwEP89JyQNZlNicbqFedKlp1tG6suahnrc0KPmIb6sukitgnVWfWFWrv1Cq0SIapDjjXkZ9q X-Forefront-PRVS: 0098BA6C6C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(199003)(189002)(377424004)(24454002)(377454003)(81156014)(66066001)(19580405001)(2950100002)(4326007)(105586002)(4001350100001)(97736004)(106356001)(31686004)(47776003)(65956001)(42186005)(65806001)(33646002)(230700001)(77096005)(50986999)(54356999)(23676002)(101416001)(3846002)(6116002)(586003)(83506001)(110136003)(50466002)(36756003)(31696002)(76176999)(7736002)(305945005)(92566002)(189998001)(7846002)(6916009)(68736007)(6666003)(64126003)(19580395003)(65826007)(2906002)(86362001)(5660300001)(1411001)(81166006)(8676002);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB390;H:[142.133.110.144];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzOTA7MjM6TjA1VStObWYvOVU5cUdPcUg2TVdVSFFBKzJX?= =?utf-8?B?aWd0aGRldWd3ZkRiSEZZZkxieWcvdHdhZlA1Ykh5YTloOVpraklicHFLckRz?= =?utf-8?B?bDQ1RkhTa1IrY1d0b3JZbzhRSTZFeC9sazNVRTlOMitBV3labmd4aktnODhx?= =?utf-8?B?VGVwNjZtOEU1bnRBWkhkK2VxTWlqZGpxOG4weHdaM0krYXZOUDJHQUFLVk85?= =?utf-8?B?MWtNRXJRelhuQ2pqUmlDNlZzK2ZURGZPMWc2SnhGT0RFN09xYlpzR29kbEZ4?= =?utf-8?B?VkloZ3czTGpFUVE5V1RmYmdaeW5MYUh0Z1VZYnFCZ0tFenF0VkFzS0NsR09k?= =?utf-8?B?bFNVQVVzekorRzJFS2FDL3BXWnRQRS9Xb1ZoWUZaYjZHaXh6MzRQamdFSHg4?= =?utf-8?B?OFpCSko3NllWZ2NCTjd3dm9oYlJYcjBnWEFvS1hOZG8xUkY4eWF5d3U3ZGNE?= =?utf-8?B?L1VDOCtwbDhUSDJkbDNlSmJkdkdzTVRBU2FEMGVZb2Y3MnJSTHBteHhjVVFw?= =?utf-8?B?VG4yeE81MkllSFlscjZXWFIwTGN6YVlOWmJLeXB3S1hnOForMWpMaG5ST1I1?= =?utf-8?B?Y2tPT3R3SVdQQ0h2WTV0WWg5bWcwUjJNdkhlVkwzdmNuWmJrbmRoMDNDUXJO?= =?utf-8?B?Tzhyem5VYmNUNW41OU5xbDJ3SnFwb3BVWHhIY0lHUEIyQkF4NDNBTmtENFda?= =?utf-8?B?TXRJdEI4MC9UR1l0czJWdUE4eUlQWjhTcHVaUWVCRnI3SWVmMFhyT01rQzdp?= =?utf-8?B?M3ZZYTNDQzZYdG91c1ZoRDl1T2pjVXpvK3BUVm4vSmxOYklCUXFqcUgvZFcz?= =?utf-8?B?WlZvVXZPcEEzWlh5cXdzMVE3ZnU2ODRkKzNMY0t2dDdvTzVvdktvK3FWVWE4?= =?utf-8?B?YzZBcWVhQ003aDhRaldwN0RmVW16eFBWTGQyTEU3Z1VIVVhnR3k0d2xmeHpK?= =?utf-8?B?UHpacTBoRVBVUk1XUWxkQjNzYm54aGRFMFZwN09ZZzlISFVwOXNOWDFlUkx0?= =?utf-8?B?NTRWMUtaVWtvaktpK0tvNzBhb081VnAySHFBdFdUUStYT09BUGZNNnRzaSsy?= =?utf-8?B?ZGx1Y01obERLZXlWbzU0VTNQY0s2K214eU9JcVhpUDZNakkyTk9SUjJlTDB1?= =?utf-8?B?NXplY2ZMTG95eVc4ZXQ3b09CeTBqYXFVWHVvUDd6SHpCYXFJb1dYKzl4M0ZE?= =?utf-8?B?SEM2bGMxME5UT3dJVjg0NmtSRHBIR29JTlIxbGlSb2hQYlBDbkhqMlRxWkhU?= =?utf-8?B?Zi9YOXcyUmFuSVhocUVMRncrb0JFRUNNQm12YnVheXA4MU9zOWdIYVRmVHlW?= =?utf-8?B?blU1ZHZIV2VJMTVTRWdvLzhTeEIwYjZ4bW04bmNjZUJEcTVSQWRTNEI1dWE0?= =?utf-8?B?YXMwRGljaFY3MUw0M2psRk1LRUN2VjF4YUFNYTVBdWgxZS9FYk1MZnRRY1ln?= =?utf-8?B?dHhLUUJIc3FJbmFzOFJueU1rQjduS1ltZng5b0hYWG94L2NmcU5FMzVEaWR5?= =?utf-8?B?VktGL2djM1JQQXRYaDljMEQzWWdZaXBBN1BNeFBaUU11dXRoZFp0NXBPV1RX?= =?utf-8?B?VDlseUFRZFYwa1RCenc2dThJblI5djNPcUJDZytnWXE5S1orSnAyT084YjNE?= =?utf-8?B?VWN6amZPT096NW9TRnZDSjVCUC9SZXV0R005dVhjQllZMU1ZQVVza0ZMM1pi?= =?utf-8?B?ZWI5Mk9wVHNvR215blU5ckdLeHFrNDE3eUp6cXRLditVT2wyY3NneEpEc1Nv?= =?utf-8?B?UVpSYWVUUkJFMFpBdWFKanhiR2N6VHFDeVhBOHk4bXc5ZnZGTEZYbUd2cnhF?= =?utf-8?B?OFVIVDJkSTVadHlEN3p4cUxTcHJnQTFMREV2a2xFTXhINHhSU0VtU0lUQkh0?= =?utf-8?Q?RFIKEud9KM=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB390;6:kz7DouaE9pX2lF1LQaIJ9eb0CUr95z2CKKzlF1Y32X5EFwC5Sm0bj4gAOJAXhJkk29XAPRJYVwAlONOoc7B/5CO4ModREJAzUUHvp+8gejUdF784P25WyyzxuX0m+kJtXkbkvwaHbuC0pFPQw0+3sYH56AkYzMb7pCR24lZkbQ9l8oO5gcJWJL2lHDqCH9gO7+XnPbYmO1bchd7tbuHCJO18yQRHK9b7NfhsBtE+6jT23taRSixCAOLqOhr6FCAoXoS2Ra75OX3ai4JWMbc8UN9/KHFTe2qZsaQBtlvz0EfrJJgCpijrN1v5zIjjMFOi;5:X0O1PPOKPJGLae6cEl6+6zObutcTe1g4iaHckCyY72X+aow5pwJpvbfl+E1JXGiFS9ojQwGlsb8E7CRKowsdHLsvh2mZLfR/QhXlhb/Pwz7GXsj3rcMFWFoxrth6sm0qX8IM3IbpqIZe+AuKjKLNRg==;24:JbOcFQx6rWWODITJk8hFhdb/mdadTZ+eFs+H6RKFuVHMHfjtpaoDfdvmPahoElZVxf6hb1pa55t3z6V1h/5kLERS5w9hs+jXGiKiQDsiJBw=;7:mFN7n+RHA0RRdJLEky5inWsuVCcnV/jXXHeqQDMOt20zwA85ic3sIkhx2U1/22S9o6HNkz+uDLE0ExCD2zitxl1NufO82jYzkcK6ATjkHKEPFnoNqGI6l5MBYxnvUS8KM5vGJ3soydU6iJP0OQ1+Ak1jDPq1aHEk3XKrrLeViyrMyJYaDHeTjBbLJTEela62QYjTmxQ9NA2OdebekgoNG9hluWGFWtyFEde0hNiaSHy/zHk9K7r/8D6+pGcfypOXylzxUDPUE3QH4585okd7b9W6DzKP5qq8cSPfQpprB9wIjBMigvZDUDnReStkYfVhC6fuadfkQ9vTyaTOuMSiS2tip8pyJ3h7kbqn4Gq+hho= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2016 20:36:57.1246 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB390 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00490.txt.bz2 On 16-10-17 04:08 PM, Yao Qi wrote: > HI Simon, > Patch is good to me. A nit below, > > On Fri, Oct 14, 2016 at 4:25 PM, Simon Marchi wrote: >> + >> + if (oind >= argc) > > Nit: if (argc - oind != 1) > >> + error (_("Argument required (file in which to save trace data)")); >> + Good idea, otherwise giving too many arguments still works, when it shouldn't. I'll change the error message to: "Exactly one argument required ..." Thanks.