From: Simon Marchi <simon.marchi@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix -trace-save crash when argument is missing
Date: Mon, 17 Oct 2016 20:56:00 -0000 [thread overview]
Message-ID: <28f9b2c1-a6db-db14-65ae-63e4630381b1@ericsson.com> (raw)
In-Reply-To: <bfd87ce5-5d94-28c8-5811-b4c62f391b04@ericsson.com>
On 16-10-17 04:49 PM, Simon Marchi wrote:
> Pushed. Here is the final version:
...
Oops, I had forgotten to update a comment. I pushed this quick fix:
From 3ccdb4324b0dc9fa46ee7cad9b370f8c7c370c3b Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 17 Oct 2016 16:54:24 -0400
Subject: [PATCH] Fix comment in mi-trace-save.exp
This fixes a comment I forgot to update in the previous patch.
gdb/testsuite/ChangeLog:
* gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
Update comment.
---
gdb/testsuite/ChangeLog | 5 +++++
gdb/testsuite/gdb.trace/mi-trace-save.exp | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index f0c8415..9d35283 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,5 +1,10 @@
2016-10-17 Simon Marchi <simon.marchi@ericsson.com>
+ * gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
+ Update comment.
+
+2016-10-17 Simon Marchi <simon.marchi@ericsson.com>
+
* gdb.trace/mi-trace-save.exp: New file.
2016-10-13 Yao Qi <yao.qi@linaro.org>
diff --git a/gdb/testsuite/gdb.trace/mi-trace-save.exp b/gdb/testsuite/gdb.trace/mi-trace-save.exp
index 96bb70d..edb3a59 100644
--- a/gdb/testsuite/gdb.trace/mi-trace-save.exp
+++ b/gdb/testsuite/gdb.trace/mi-trace-save.exp
@@ -21,7 +21,7 @@ load_lib mi-support.exp
mi_gdb_start
-# Test without the required "filename" argument.
+# Test with the wrong number of arguments.
proc test_trace_save_wrong_num_args { } {
set err_re [string_to_regexp "^error,msg=\"Exactly one argument required (file in which to save trace data)\""]
--
2.10.1
next prev parent reply other threads:[~2016-10-17 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 20:26 Simon Marchi
2016-10-17 20:09 ` Yao Qi
2016-10-17 20:37 ` Simon Marchi
2016-10-17 20:50 ` Simon Marchi
2016-10-17 20:56 ` Simon Marchi [this message]
2016-10-17 20:59 ` Pedro Alves
2016-10-17 21:07 ` Simon Marchi
2016-10-17 21:08 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28f9b2c1-a6db-db14-65ae-63e4630381b1@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox