Re: [PATCH] Fix -trace-save crash when argument is missing

[Simon Marchi <simon.marchi@ericsson.com>]

On 16-10-17 04:59 PM, Pedro Alves wrote:
> On 10/17/2016 09:49 PM, Simon Marchi wrote:
>> +    mi_gdb_test "-trace-save" "$err_re" "-trace-save with missing argument"
>> +    mi_gdb_test "-trace-save a b" "$err_re" "-trace-save with missing argument"
> 
> Duplicate test messages?
> 

Ahh damnit!  Just when I thought it was an obvious change :).  Thanks for pointing it out.


From e42b25a0407fbbf3529815f69bd56a61b1821295 Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 17 Oct 2016 17:05:46 -0400
Subject: [PATCH] Fix duplicate test message in mi-trace-save.exp

gdb/testsuite/ChangeLog:

	* gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
	Change test message.
---
 gdb/testsuite/ChangeLog                   | 5 +++++
 gdb/testsuite/gdb.trace/mi-trace-save.exp | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 9d35283..4ecf0b7 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,6 +1,11 @@
 2016-10-17  Simon Marchi  <simon.marchi@ericsson.com>

 	* gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
+	Change test message.
+
+2016-10-17  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args):
 	Update comment.

 2016-10-17  Simon Marchi  <simon.marchi@ericsson.com>
diff --git a/gdb/testsuite/gdb.trace/mi-trace-save.exp b/gdb/testsuite/gdb.trace/mi-trace-save.exp
index edb3a59..156ec54 100644
--- a/gdb/testsuite/gdb.trace/mi-trace-save.exp
+++ b/gdb/testsuite/gdb.trace/mi-trace-save.exp
@@ -27,7 +27,7 @@ proc test_trace_save_wrong_num_args { } {
     set err_re [string_to_regexp "^error,msg=\"Exactly one argument required (file in which to save trace data)\""]

     mi_gdb_test "-trace-save" "$err_re" "-trace-save with missing argument"
-    mi_gdb_test "-trace-save a b" "$err_re" "-trace-save with missing argument"
+    mi_gdb_test "-trace-save a b" "$err_re" "-trace-save with too many arguments"
 }

 # Test with an unrecognized option.
-- 
2.10.1