From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 389 invoked by alias); 17 Oct 2016 21:07:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 372 invoked by uid 89); 17 Oct 2016 21:07:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Oct 2016 21:07:08 +0000 Received: from ESESSHC018.ericsson.se (Unknown_Domain [153.88.183.72]) by (Symantec Mail Security) with SMTP id 6F.6B.31035.97D35085; Mon, 17 Oct 2016 23:07:06 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.72) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 17 Oct 2016 23:07:05 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.110.144] (192.75.88.130) by AMSPR07MB389.eurprd07.prod.outlook.com (10.242.22.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.679.5; Mon, 17 Oct 2016 21:07:02 +0000 Subject: Re: [PATCH] Fix -trace-save crash when argument is missing To: Pedro Alves , Yao Qi References: <20161014202536.21670-1-simon.marchi@ericsson.com> <528b1dbb-7ccd-ab73-b561-4216ab52e8b8@redhat.com> CC: "gdb-patches@sourceware.org" From: Simon Marchi Message-ID: <351d76ce-683c-eebc-9f7f-16f66d1e2d4c@ericsson.com> Date: Mon, 17 Oct 2016 21:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <528b1dbb-7ccd-ab73-b561-4216ab52e8b8@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN1PR02CA0032.namprd02.prod.outlook.com (10.141.56.32) To AMSPR07MB389.eurprd07.prod.outlook.com (10.242.22.11) X-MS-Office365-Filtering-Correlation-Id: 447c3568-23db-4cec-64c9-08d3f6d18af3 X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;2:KJdMrv3oza2hvVDZB/Uu2yI14fydituLrU/MpFp7oIDgFbbyfeLDq75kD1N6l+8QCwr3Ak9yY0FJud68PojkrUu7HjvVwgTxuVJqHHrKQmugUCLijaTxF4QheMdvafn1iVwg71FnSdUtUYMgRnHDtiGAv8V7Wg4wiEq9cRh5gFr9PpPLX3yHW+XQ+1qISULgs6E2D7/rbnozrZzSjzZMeg==;3:P8MVVuKFSHvVPyxth2dBBvC/ugIVq57DdRY2aloiM+ecKjYMFuYBCpG/iew7Denw5KYoJ5fqtELonPR8TNjqPEQcbo6JAM6rZRpc07xOdZAf5T4hh5Fn3dul7sTRi27YMfEL/kV8v8ew7aTfiwB1TQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB389; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;25:UXBOZZQW/Ov0Gz8VrvQu5Tc2OScy/VRtAs5WgfIa+4xs/cWABH3LRfFEZKhI2s3cLAGeANvcG/7OSb7yk3phKKohwwHXVHi1Nd18sPDVZ8vb8erSqknBAI72I8QIEn3ZX98NeIp2jjJDPn+lG7A9z5zJuqH3mK7Ka5v0YFWFlmdECREW01y9SKvRCbbLwyJuxIYl8XaAslOD3wV7Yma9nwNdarY4FhhifjVGCML8Fo+szfehv3+PFXkIkSvBzm8FE2JVZ8a7A2dvfg1DI9CoC/3zcfRNe5oxkvcgXbs+n8dUoM8MvoIT0UggJRGH7vFgrORcfV8lnb8F+eZBBGe+MnieAZHtmChURaKWXi+s5aLc5Tn5TEXBhGeSyZfz1mJ8hwzNpsyE7qO8uSEYwGlZXKzF6uq/goxJ2/pmQttt4eDgQaAYRgy5nEu4jcCS5UuO6SvgYwF/dseN3ovphn4jH/7mcKezbpLXn84INPm23Ip3rzTJUg7fKkcgyfqMWNA8d1qxKPtClnkZP965iNzFk/7sijX8grZkgC2m79c1oovFg1tWKrBxmPBQoAgJ8nw6xlF2gh8M4xcSyvqbpQ2o8c1BeU+oteTiFiYZ6iKQtLDCpmvlFTbBk3gpzT3nJz5lCgsK6bDkmJMtUa+CSWoHmyuCgEJswjZQepzMSsrDUVZwspU2pRCpLu99VocOrIFeKMXc5pVXFfvE/PyekrDP9PPg7xHdGoZJGwmZkHSrVgQ84hk6XxubxRQwpkSsXBF4 X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;31:9w1y1g8QNFv7Lsv5l2+Y4jk5QqElutHjVlRW5kFqtu16kZ9j7ZIkOlrVvuajUFQzUqbe96oHbc32SJYaZU5OtR3F4oa6u/s+oq53/9H3mQ/SYqVVM+KEk36hjmR88QkTYFoHKL3QdTavNwQQuZUSQtSlgYzaDnh8boh13VRDiYRWaJNy9ao89Ow3m6VRMJuW857iVmw0zekJsmws3VDOe5sdYT7nyqCi9N/mSu6t1g6bdIcqWiNmwrdL/yL+dwHALl9I9dDPj/nctkHlgZ/AAA==;20:syi0Uh6BUntg+shDwcpYlQrPrZ2Y4k+GYKEWY/lg7d70eppsZDrZNpQC7M7v/siF5R2qUiTPjObFb/HgrrKf/lU3uh4wuYwpPRohuXRuUkqN0YXm3KOkyCSamgqLaCmJ8h6cVcpilytLQEk0BrEZiV8ic2zGOv5bSBOXJiZzH+QQztj6O3rf4BvSP9mKi34dAWWYatgse0iDPojJSNQNE8b3WBj3HupeydUJfGbq4zoRrd9r17oqJbzP+2zCYvlwcitll9TciaIxRL9s6SGtbMX+EhayENyaQizLQq2KxP8VaTtXygqqCQ2dgiWLzjkY+nAyAPt+ucQwVQEeWqkhXRQ9Dw943uvz3IzApjYV3fRyh87wOQb8Ioj5lycU3wr0+6LJC4o26oclabKGi7NKASU/y1lY1NtD3M7JDQsqjVVkmlJKHDyl6V0ahLvSEifqugchBCPGP6rRFNmlLGZ4ZzB4urccwQNzbsTJSLCWDuuBLBk4P1PRtC3V3HWvQ0L9 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:AMSPR07MB389;BCL:0;PCL:0;RULEID:;SRVR:AMSPR07MB389; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;4:wShBcH10UrD8fR9ydD9OcXU1HemVdhTO5sBZMrce18nOE/mvY4q7UOlhuri35zAQ9YJf9ATV6fXE6GWsdHlLPyS6Pm9x/u+5GKFLAccZ4sRJWebxc5vBUS93LinLnADrb9KmnWqdNWJxPfR9fCNREQ4VD1LOqBPI8DShEn2e0ryKY/nve2gJtC4w90AAcZ8EiXOYr+auK51aOLK2/abkQA0Oepk2wvBhdk1ONHCIkR1hnUL7tYwB5OndzJ0hkszMcNV/bBbzHf9oBeC490ws/Y3SENqa6oZnL41l1JaSUYBfIGL5ThZQEfU3GE+W7iRU/yK4POIqBftx/64H25fvBRvCiQIeiBcap7kR5zJ7HgP5Iu125FL6agngqWexTNE1XIshulwpfQyQ+NflKWnuXcbn6EFqNem2BwEsU1rv4lU01SpO/BiwnnlNGfWsNyTiW2xhc5ywVnwsHi566pvBJw== X-Forefront-PRVS: 0098BA6C6C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(377454003)(24454002)(54534003)(199003)(189002)(377424004)(47776003)(7736002)(36756003)(50466002)(81156014)(81166006)(65956001)(3846002)(6116002)(586003)(19580405001)(77096005)(101416001)(93886004)(54356999)(76176999)(50986999)(64126003)(19580395003)(106356001)(105586002)(5660300001)(230700001)(31686004)(42186005)(2950100002)(6666003)(4001350100001)(5001770100001)(97736004)(65806001)(305945005)(66066001)(189998001)(68736007)(2906002)(4326007)(23676002)(575784001)(86362001)(83506001)(4001150100001)(33646002)(8676002)(31696002)(92566002)(7846002)(65826007);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB389;H:[142.133.110.144];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzODk7MjM6OFFkaFhDVCtrY3JraDcyVkdTZWRPem5QaGNm?= =?utf-8?B?cXBvMXYraTVCWHFPanZwNlJmeFFLUG1yRUtCTTZ4TEJiSE9FSE1sVHhiTXkv?= =?utf-8?B?NUJFMTU1dittQUYwVGdsOWRKVm1PTkRtcytwS3ZKa2VHK2ZYY3MwelhXRVRX?= =?utf-8?B?OS9mVm5XT1VBdFBxR1kwQ3lRcnA1bGVVUkNtSENia3JPRyt6eVIzR2Q0bnBz?= =?utf-8?B?M2VPblhhY3dQNFh6ZEg2RzArWDlzMC8wR29YZXVTNGk2WTVQZlNNUzBLSnIr?= =?utf-8?B?VzFIVmNxYkJJYzdGL2dDYkV2Rm5sR0NFUHZUWmN6NHlINW51ekZDMkdoTWFw?= =?utf-8?B?T01mMDRpTDcrRHRzTHgwMXF3V1ZBUGExUjdyc2NNd2hoeVFXek1KTElQLzht?= =?utf-8?B?eEl4Z2IvSGZoV0dMOW55TDFOMlBZVExJaDR2R3VCekxCSlVxNkNrSFI0V1Rj?= =?utf-8?B?akJaNTNNYW5QWjRXejBTM1RrSW92MmVSd1EvSGIzR05aOVFWdTFGa3BNbW84?= =?utf-8?B?ZVh4RFovSTA5YWdOdmppV0podi9qZk5VUm85enZuSmN4YjJITzR5RjAwRlRl?= =?utf-8?B?d1hoUzkvSlRsbjJmOGRjeVA0QUxnbElabGlPaEFiUU5qSUdqcE1kanNTL0pr?= =?utf-8?B?SmZTamhVQ0h0ek94UFB0c0dmYzZ3c3J1bGdPY3ZmZHUvTkQxL2paL1B5aVJp?= =?utf-8?B?OEh3YzZMdnRBM2RNaDdHRG9mYVowS2lHYndxaUxVMExxb2JQcDBjZUlPNFZ2?= =?utf-8?B?Vi85b21rdDFpdjF6M1VGTmxZTy9BTTFFY2VHcXpvbHNJV0lzb2ljaEtiVFhX?= =?utf-8?B?Sk1lR1RORVM1NjVEUmFvMTNIeEdvSFU4ZEczcTYwK1RLMU9tOHZ4b05uTUE1?= =?utf-8?B?U3AzdlQ2OXNWT3had2pVby9oY3lhVjA5NndUQkF3ZnVHVEszSjVHbGp2VmZI?= =?utf-8?B?NEc2YUFsRC9iRDhGb1dJaXpidnllNGRTOWgrYm50WHhSYVAvcXdOc0FFdVYw?= =?utf-8?B?cmV6cHFoZ0xjcjEzK3FTNVpXMWI1N0djekJBdEc1UUVFTzBONmRpZXJYbGZQ?= =?utf-8?B?UndOYlJhdFJMKzdqZWF6WEMxWllLWE1JaEd2M3gzNjlKdUZEWGZLZUtCUHlQ?= =?utf-8?B?MkZyOEZOWS84VTgyRUxpem0rWDBwSjNMMldxMzdRdDZzTGZPRHR5N1p4TE9s?= =?utf-8?B?dFZVMThGZ0V5aE1JUkFLNko1T2dPTFNIM2JHcHg0LzN5TG11Y0VuSTdSYXBS?= =?utf-8?B?eHRMMFdvKzJSSkw2Q0dJK1hzR0RKNnZsQkNGY1hlZWk2cW14cmJyNGhWZElT?= =?utf-8?B?Skorbjc5citiNHp1MHJSUTdrS3N4YmYzWE1uQ1dmOG1UaUVaK3QxbmhZdXZS?= =?utf-8?B?MTBuVFBqNG04bVRBaS9XQ2RkUmZjVWh2Z2JxSmw0TjJrRG5IZ1NqREw4WGNV?= =?utf-8?B?MWNtWjZmTS9FNFpFd1FSVExOa2M4bGVqSFZmVEdmSnp0MUlxcnNZKzFXZ2pr?= =?utf-8?B?MUp3REh4NDgzRS9NZlgxNjRvMlJHWkM2ZEVLWlZaaEFUZERRQytlZ2JNQVpM?= =?utf-8?B?MkxSMnIxNVhtdTJVYlpieU5JRHhWR1lWMEhxQjZOUlZDdnAwajFMSnRubk50?= =?utf-8?B?VXh1SFVRMnJ0WHZMTkhpb2EyZUVJVnNTYjNjdGhValhjRkFpTEFGMjJYdytY?= =?utf-8?B?Y1ZDcXprWGZKbVVrNEJZcktVTXQwZGRsRGpabm92cExkNlVLL2NtSk9tNDNi?= =?utf-8?B?U1ZaYVZ0aTJVTVR1dTRwQ0YvNGtZUCtsRUFoN2JKQ085d28vMU9ETjdwejdQ?= =?utf-8?B?eEM2SlVaZzhOSjc0MU0rQjFnVi9qMjByclptVlYrOHR3S0FNTkdOTmVjQU5D?= =?utf-8?B?V21OQk5FTEJNY28zY3VnZ2JUaXltRk1Mb3BFUzhMU1dOYlNnSHdSdnV1TDhN?= =?utf-8?Q?9tsb+dyybnarEexr2J0ZBWLmRfkzM=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB389;6:w5U7tWf2l6sBELl5DunYMjwpYRHUGzk3lQu7FpDuG6rlP+aeCBjXJ5p4WccLsgVyHifdd7Pe1YRbpc4Ab/uLbmKqEIAYAGdhosj8vVk12oQKxeHwmvzXLUIk+R2dqpAjT31xZUrHgcTvyucSTsDCXeHnCllLnDpsqO133xhRksKGhpHonKQzD9VrXMKRV91Emb3vGyl2de3BIiC89E1g8h2nNVObuFTRM0ewS4kocVnD7CbJpmpwVlJLOqq92UrkYDF15bV17l32caJnAjfGDWJLo+TAMsB3ne8xzEv0tqjjkWKGcwYfKhhyoA4TJb0L;5:OjM1specxYIav/hG4NPtqOfD5BN9NDZesJPq6yE7aK2g4TTzKkrrerN0pR6UY1LZClRH6jscsDfj0YHKd4oJZGL//qW5d2OSMFusSlmLPIAweBcUus9EbxmfG70tz8H8xlzEXgALMrbQazcuhtaKbFVAaCAKvC8kwgr/kHhbBGQ=;24:ewozvx4k4pyVDNyrOH66ZJbXB9Y6BLwMZF+aYAwl7mkST69Rsp+7t/ppzb1Wc4upEqdIyRNNbqBM/Nj9y9r3gXqlU2l4VdIdD3MX/coT6Ac=;7:XsADSLdk4TXrnlVShFL1rsfArdDW0RhnZhH+B0NCtn2y9rQO/DAIJ/MRMuYVEGQNUaNA4w0mWxR+4JVjrLfCrwO0cpavzz8j919v0Ins/IboENdbee5D3QqCU8cbFy07AfHd9VqwJeLGSKZnZioPp3olZgGJtgs5xq8Bx394hPRQW/pDSHiziccrjhwT8Ewzt7j66ciyGEwsK5PswKeaoVL/PhwZ2ZmPaTu/tSlaXjpSF/Nnnht9ITMPRMAAJbv1ObSCETmznFko8ysKE7qxAr4nVU+NOKYhVfardaqjflzx4oIKIvS2iUuIWMqh+1zBrK8b8gVGatjc18tuuRhm4Dw0yw7KUrrLBfhNuD7AoHQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2016 21:07:02.2931 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB389 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00494.txt.bz2 On 16-10-17 04:59 PM, Pedro Alves wrote: > On 10/17/2016 09:49 PM, Simon Marchi wrote: >> + mi_gdb_test "-trace-save" "$err_re" "-trace-save with missing argument" >> + mi_gdb_test "-trace-save a b" "$err_re" "-trace-save with missing argument" > > Duplicate test messages? > Ahh damnit! Just when I thought it was an obvious change :). Thanks for pointing it out. >From e42b25a0407fbbf3529815f69bd56a61b1821295 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 17 Oct 2016 17:05:46 -0400 Subject: [PATCH] Fix duplicate test message in mi-trace-save.exp gdb/testsuite/ChangeLog: * gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args): Change test message. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.trace/mi-trace-save.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 9d35283..4ecf0b7 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,6 +1,11 @@ 2016-10-17 Simon Marchi * gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args): + Change test message. + +2016-10-17 Simon Marchi + + * gdb.trace/mi-trace-save.exp (test_trace_save_wrong_num_args): Update comment. 2016-10-17 Simon Marchi diff --git a/gdb/testsuite/gdb.trace/mi-trace-save.exp b/gdb/testsuite/gdb.trace/mi-trace-save.exp index edb3a59..156ec54 100644 --- a/gdb/testsuite/gdb.trace/mi-trace-save.exp +++ b/gdb/testsuite/gdb.trace/mi-trace-save.exp @@ -27,7 +27,7 @@ proc test_trace_save_wrong_num_args { } { set err_re [string_to_regexp "^error,msg=\"Exactly one argument required (file in which to save trace data)\""] mi_gdb_test "-trace-save" "$err_re" "-trace-save with missing argument" - mi_gdb_test "-trace-save a b" "$err_re" "-trace-save with missing argument" + mi_gdb_test "-trace-save a b" "$err_re" "-trace-save with too many arguments" } # Test with an unrecognized option. -- 2.10.1