From: "Rob Quill" <rob.quill@gmail.com>
To: "Mark Kettenis" <mark.kettenis@xs4all.nl>,
gdb-patches@sourceware.org,
"Daniel Jacobowitz" <drow@false.org>
Subject: Re: Remove deprecated_set_value_type (part 1)
Date: Tue, 26 Feb 2008 14:36:00 -0000 [thread overview]
Message-ID: <baf6008d0802260441r3f54ce54hed4a13b01c6a75d8@mail.gmail.com> (raw)
In-Reply-To: <20080226012037.GA4456@caradoc.them.org>
On 26/02/2008, Daniel Jacobowitz <drow@false.org> wrote:
> On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote:
> > There are some code style problems here too, and although they're not
> > your fault, it'd be nice to fix them while you're there. Actually, it
> > looks to me as if the temparg variable is completely redundant now, so
> > the above could be simplified to
> >
> > val = value_addr (val);
>
>
> Mark's right; also, there are still formatting problems with the patch
> that I commented on the last time I reviewed it :-( Rob, let me know if
> you'd like me to point them out individually.
Thanks. I'll take a look at this at some point reasonably soon, I just
have quite a bit of other stuff to do at the moment.
Rob
next prev parent reply other threads:[~2008-02-26 12:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 4:53 Rob Quill
2008-01-29 20:07 ` Daniel Jacobowitz
2008-01-30 12:06 ` Rob Quill
2008-01-30 18:06 ` Mark Kettenis
2008-02-26 2:24 ` Daniel Jacobowitz
2008-02-26 14:36 ` Rob Quill [this message]
2008-07-27 19:16 ` Rob Quill
2008-08-09 15:10 ` Rob Quill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf6008d0802260441r3f54ce54hed4a13b01c6a75d8@mail.gmail.com \
--to=rob.quill@gmail.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox