From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54241-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18089 invoked by alias); 26 Feb 2008 12:42:04 -0000
Received: (qmail 18078 invoked by uid 22791); 26 Feb 2008 12:42:03 -0000
X-Spam-Check-By: sourceware.org
Received: from wr-out-0506.google.com (HELO wr-out-0506.google.com) (64.233.184.224)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Feb 2008 12:41:45 +0000
Received: by wr-out-0506.google.com with SMTP id 37so4058153wra.12         for <gdb-patches@sourceware.org>; Tue, 26 Feb 2008 04:41:43 -0800 (PST)
Received: by 10.114.156.1 with SMTP id d1mr5338940wae.68.1204029700794;         Tue, 26 Feb 2008 04:41:40 -0800 (PST)
Received: by 10.114.102.11 with HTTP; Tue, 26 Feb 2008 04:41:40 -0800 (PST)
Message-ID: <baf6008d0802260441r3f54ce54hed4a13b01c6a75d8@mail.gmail.com>
Date: Tue, 26 Feb 2008 14:36:00 -0000
From: "Rob Quill" <rob.quill@gmail.com>
To: "Mark Kettenis" <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org,  	"Daniel Jacobowitz" <drow@false.org>
Subject: Re: Remove deprecated_set_value_type (part 1)
In-Reply-To: <20080226012037.GA4456@caradoc.them.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <baf6008d0801202053w5aaa9ee1pf4cde2b15ec8fa53@mail.gmail.com> 	 <20080129195506.GE9019@caradoc.them.org> 	 <baf6008d0801300338n119405c1x9d6507001ea4e945@mail.gmail.com> 	 <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl> 	 <20080226012037.GA4456@caradoc.them.org>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-02/txt/msg00387.txt.bz2

On 26/02/2008, Daniel Jacobowitz <drow@false.org> wrote:
> On Wed, Jan 30, 2008 at 07:04:40PM +0100, Mark Kettenis wrote:
>  > There are some code style problems here too, and although they're not
>  > your fault, it'd be nice to fix them while you're there.  Actually, it
>  > looks to me as if the temparg variable is completely redundant now, so
>  > the above could be simplified to
>  >
>  >               val = value_addr (val);
>
>
> Mark's right; also, there are still formatting problems with the patch
>  that I commented on the last time I reviewed it :-(  Rob, let me know if
>  you'd like me to point them out individually.

Thanks. I'll take a look at this at some point reasonably soon, I just
have quite a bit of other stuff to do at the moment.

Rob