From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: rob.quill@gmail.com
Cc: rob.quill@gmail.com, gdb-patches@sourceware.org
Subject: Re: Remove deprecated_set_value_type (part 1)
Date: Wed, 30 Jan 2008 18:06:00 -0000 [thread overview]
Message-ID: <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <baf6008d0801300338n119405c1x9d6507001ea4e945@mail.gmail.com> (rob.quill@gmail.com)
> Date: Wed, 30 Jan 2008 11:38:32 +0000
> From: "Rob Quill" <rob.quill@gmail.com>
>
> Index: gdb/c-valprint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/c-valprint.c,v
> retrieving revision 1.48
> diff -u -p -r1.48 c-valprint.c
> --- gdb/c-valprint.c 11 Jan 2008 13:34:14 -0000 1.48
> +++ gdb/c-valprint.c 30 Jan 2008 11:20:33 -0000
> @@ -562,8 +562,7 @@ c_value_print (struct value *val, struct
> * error about a non-pointer type in value_rtti_target_type
> */
> struct value *temparg;
> - temparg=value_copy(val);
> - deprecated_set_value_type (temparg, lookup_pointer_type
> (TYPE_TARGET_TYPE(type)));
> + temparg=value_addr (val);
> val=temparg;
> }
There are some code style problems here too, and although they're not
your fault, it'd be nice to fix them while you're there. Actually, it
looks to me as if the temparg variable is completely redundant now, so
the above could be simplified to
val = value_addr (val);
next prev parent reply other threads:[~2008-01-30 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 4:53 Rob Quill
2008-01-29 20:07 ` Daniel Jacobowitz
2008-01-30 12:06 ` Rob Quill
2008-01-30 18:06 ` Mark Kettenis [this message]
2008-02-26 2:24 ` Daniel Jacobowitz
2008-02-26 14:36 ` Rob Quill
2008-07-27 19:16 ` Rob Quill
2008-08-09 15:10 ` Rob Quill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=rob.quill@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox