From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53774-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8038 invoked by alias); 30 Jan 2008 18:05:04 -0000
Received: (qmail 8025 invoked by uid 22791); 30 Jan 2008 18:05:03 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 30 Jan 2008 18:04:46 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1) with ESMTP id m0UI4e06018129; 	Wed, 30 Jan 2008 19:04:41 +0100 (CET)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id m0UI4eWR018093; 	Wed, 30 Jan 2008 19:04:40 +0100 (CET)
Date: Wed, 30 Jan 2008 18:06:00 -0000
Message-Id: <200801301804.m0UI4eWR018093@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: rob.quill@gmail.com
CC: rob.quill@gmail.com, gdb-patches@sourceware.org
In-reply-to: <baf6008d0801300338n119405c1x9d6507001ea4e945@mail.gmail.com> 	(rob.quill@gmail.com)
Subject: Re: Remove deprecated_set_value_type (part 1)
References: <baf6008d0801202053w5aaa9ee1pf4cde2b15ec8fa53@mail.gmail.com> 	 <20080129195506.GE9019@caradoc.them.org> <baf6008d0801300338n119405c1x9d6507001ea4e945@mail.gmail.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-01/txt/msg00806.txt.bz2

> Date: Wed, 30 Jan 2008 11:38:32 +0000
> From: "Rob Quill" <rob.quill@gmail.com>
> 
> Index: gdb/c-valprint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/c-valprint.c,v
> retrieving revision 1.48
> diff -u -p -r1.48 c-valprint.c
> --- gdb/c-valprint.c	11 Jan 2008 13:34:14 -0000	1.48
> +++ gdb/c-valprint.c	30 Jan 2008 11:20:33 -0000
> @@ -562,8 +562,7 @@ c_value_print (struct value *val, struct
>  	       * error about a non-pointer type in value_rtti_target_type
>  	       */
>  	      struct value *temparg;
> -	      temparg=value_copy(val);
> -	      deprecated_set_value_type (temparg, lookup_pointer_type
> (TYPE_TARGET_TYPE(type)));
> +	      temparg=value_addr (val);
>  	      val=temparg;
>  	    }

There are some code style problems here too, and although they're not
your fault, it'd be nice to fix them while you're there.  Actually, it
looks to me as if the temparg variable is completely redundant now, so
the above could be simplified to

              val = value_addr (val);