Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH 0/2] [gdb] Add missing copyright notices
@ 2026-03-26 17:02 Tom de Vries
  2026-03-26 17:02 ` [PATCH 1/2] [gdb/contrib] " Tom de Vries
  2026-03-26 17:02 ` [PATCH 2/2] [gdb] Add missing copyright notice in pyproject.toml Tom de Vries
  0 siblings, 2 replies; 6+ messages in thread
From: Tom de Vries @ 2026-03-26 17:02 UTC (permalink / raw)
  To: gdb-patches

Add missing copright notices in a few files.

The first patch does so in three files in gdb/contrib.

The second patch does so in gdb/pyproject.toml.

Some of these files are so small that they can be considered trivial, and
consequently don't need a copyright notice [1], but it can't hurt to add one.

[1] https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html

Tom de Vries (2):
  [gdb/contrib] Add missing copyright notices
  [gdb] Add missing copyright notice in pyproject.toml

 gdb/contrib/codespell-dictionary.txt   | 23 +++++++++++++++++++++++
 gdb/contrib/codespell-ignore-words.txt | 21 +++++++++++++++++++++
 gdb/contrib/setup.cfg                  | 14 ++++++++++++++
 gdb/pyproject.toml                     | 16 ++++++++++++++++
 4 files changed, 74 insertions(+)


base-commit: edf0ae3b9f1ca23daaa55628683edc9a3360286f
-- 
2.51.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] [gdb/contrib] Add missing copyright notices
  2026-03-26 17:02 [PATCH 0/2] [gdb] Add missing copyright notices Tom de Vries
@ 2026-03-26 17:02 ` Tom de Vries
  2026-04-10 12:30   ` [PING][PATCH " Tom de Vries
  2026-03-26 17:02 ` [PATCH 2/2] [gdb] Add missing copyright notice in pyproject.toml Tom de Vries
  1 sibling, 1 reply; 6+ messages in thread
From: Tom de Vries @ 2026-03-26 17:02 UTC (permalink / raw)
  To: gdb-patches

I found a few files in gdb/contrib that were missing a copyright notice.

In setup.cfg, it was trivial to add.

In codespell-ignore-words.txt, it was also trivial to add, but I found a
codespell issue stating that it's not explicitly support, so I added a note
about that.

In codespell-dictionary.txt, I had to resort to a hack, using an "empty word"
rewrite rule:
...
-># Comment here.
...

Also, I found that empty lines are not allowed in codespell-dictionary.txt.  I
filed an issue about these two problems [1].

Since these three files were added in 2025, I've used 2025-2026 as copyright
years.

Tested by running "pre-commit run --all-files".

[1] https://github.com/codespell-project/codespell/issues/3901
---
 gdb/contrib/codespell-dictionary.txt   | 23 +++++++++++++++++++++++
 gdb/contrib/codespell-ignore-words.txt | 21 +++++++++++++++++++++
 gdb/contrib/setup.cfg                  | 14 ++++++++++++++
 3 files changed, 58 insertions(+)

diff --git a/gdb/contrib/codespell-dictionary.txt b/gdb/contrib/codespell-dictionary.txt
index 70914421cbf..b02e6eb1997 100644
--- a/gdb/contrib/codespell-dictionary.txt
+++ b/gdb/contrib/codespell-dictionary.txt
@@ -1,3 +1,26 @@
+-># Copyright (C) 2025-2026 Free Software Foundation, Inc.
+-># This program is free software; you can redistribute it and/or modify
+-># it under the terms of the GNU General Public License as published by
+-># the Free Software Foundation; either version 3 of the License, or
+-># (at your option) any later version.
+->#
+-># This program is distributed in the hope that it will be useful,
+-># but WITHOUT ANY WARRANTY; without even the implied warranty of
+-># MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+-># GNU General Public License for more details.
+->#
+-># You should have received a copy of the GNU General Public License
+-># along with this program.  If not, see <http://www.gnu.org/licenses/>.
+->#
+-># Hack: comments are not supported in this file, so instead use a rule
+-># rewriting an empty word.  This hack may stop working after a codespell
+-># update.
+->#
+-># Note: empty lines are not supported either.
+->#
+-># I've filed an issue about these two problems [1].
+->#
+-># [1] https://github.com/codespell-project/codespell/issues/3901
 gdbsever->gdbserver
 tcllint->tclint
 recordered->recorded
diff --git a/gdb/contrib/codespell-ignore-words.txt b/gdb/contrib/codespell-ignore-words.txt
index c07df0c001d..e9c1c2dc2f4 100644
--- a/gdb/contrib/codespell-ignore-words.txt
+++ b/gdb/contrib/codespell-ignore-words.txt
@@ -1,3 +1,24 @@
+# Copyright (C) 2025-2026 Free Software Foundation, Inc.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+# Note: comments are not explicitly supported in this file [1], but using them
+# doesn't seem to cause problems.
+#
+# Note: empty lines do seem to work here (unlike in codespell-dictionary.txt).
+#
+# [1] https://github.com/codespell-project/codespell/issues/2063
+
 configury
 SME
 Synopsys
diff --git a/gdb/contrib/setup.cfg b/gdb/contrib/setup.cfg
index 4793a6264af..3aa8ac058ab 100644
--- a/gdb/contrib/setup.cfg
+++ b/gdb/contrib/setup.cfg
@@ -1,3 +1,17 @@
+# Copyright (C) 2025-2026 Free Software Foundation, Inc.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
 [codespell]
 
 # Skip ChangeLogs and generated files.
-- 
2.51.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/2] [gdb] Add missing copyright notice in pyproject.toml
  2026-03-26 17:02 [PATCH 0/2] [gdb] Add missing copyright notices Tom de Vries
  2026-03-26 17:02 ` [PATCH 1/2] [gdb/contrib] " Tom de Vries
@ 2026-03-26 17:02 ` Tom de Vries
  2026-04-10 12:29   ` Tom de Vries
  1 sibling, 1 reply; 6+ messages in thread
From: Tom de Vries @ 2026-03-26 17:02 UTC (permalink / raw)
  To: gdb-patches

I noticed gdb/pyproject.toml is missing a copyright notice.

Add this.  Since it was added in 2021, use copyright years 2021-2026.
---
 gdb/pyproject.toml | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/gdb/pyproject.toml b/gdb/pyproject.toml
index c8d1705ba15..8a62d29243b 100644
--- a/gdb/pyproject.toml
+++ b/gdb/pyproject.toml
@@ -1,3 +1,19 @@
+#!/bin/sh
+
+# Copyright (C) 2021-2026 Free Software Foundation, Inc.
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
 [tool.black]
 include = "\\.py(\\.in)?$"
 
-- 
2.51.0


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] [gdb] Add missing copyright notice in pyproject.toml
  2026-03-26 17:02 ` [PATCH 2/2] [gdb] Add missing copyright notice in pyproject.toml Tom de Vries
@ 2026-04-10 12:29   ` Tom de Vries
  0 siblings, 0 replies; 6+ messages in thread
From: Tom de Vries @ 2026-04-10 12:29 UTC (permalink / raw)
  To: gdb-patches

On 3/26/26 6:02 PM, Tom de Vries wrote:
> I noticed gdb/pyproject.toml is missing a copyright notice.
> 
> Add this.  Since it was added in 2021, use copyright years 2021-2026.
> ---
>   gdb/pyproject.toml | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/gdb/pyproject.toml b/gdb/pyproject.toml
> index c8d1705ba15..8a62d29243b 100644
> --- a/gdb/pyproject.toml
> +++ b/gdb/pyproject.toml
> @@ -1,3 +1,19 @@

> +#!/bin/sh
> +

I've pushed this patch, with this copy-paste mistake removed.

Thanks,
- Tom

> +# Copyright (C) 2021-2026 Free Software Foundation, Inc.
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
>   [tool.black]
>   include = "\\.py(\\.in)?$"
>   


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PING][PATCH 1/2] [gdb/contrib] Add missing copyright notices
  2026-03-26 17:02 ` [PATCH 1/2] [gdb/contrib] " Tom de Vries
@ 2026-04-10 12:30   ` Tom de Vries
  2026-06-01 12:54     ` Tom de Vries
  0 siblings, 1 reply; 6+ messages in thread
From: Tom de Vries @ 2026-04-10 12:30 UTC (permalink / raw)
  To: gdb-patches

On 3/26/26 6:02 PM, Tom de Vries wrote:
> I found a few files in gdb/contrib that were missing a copyright notice.
> 
> In setup.cfg, it was trivial to add.
> 
> In codespell-ignore-words.txt, it was also trivial to add, but I found a
> codespell issue stating that it's not explicitly support, so I added a note
> about that.
> 
> In codespell-dictionary.txt, I had to resort to a hack, using an "empty word"
> rewrite rule:
> ...
> -># Comment here.
> ...
> 
> Also, I found that empty lines are not allowed in codespell-dictionary.txt.  I
> filed an issue about these two problems [1].
> 
> Since these three files were added in 2025, I've used 2025-2026 as copyright
> years.
> 

Ping.

Thanks,
- Tom

> Tested by running "pre-commit run --all-files".
> 
> [1] https://github.com/codespell-project/codespell/issues/3901
> ---
>   gdb/contrib/codespell-dictionary.txt   | 23 +++++++++++++++++++++++
>   gdb/contrib/codespell-ignore-words.txt | 21 +++++++++++++++++++++
>   gdb/contrib/setup.cfg                  | 14 ++++++++++++++
>   3 files changed, 58 insertions(+)
> 
> diff --git a/gdb/contrib/codespell-dictionary.txt b/gdb/contrib/codespell-dictionary.txt
> index 70914421cbf..b02e6eb1997 100644
> --- a/gdb/contrib/codespell-dictionary.txt
> +++ b/gdb/contrib/codespell-dictionary.txt
> @@ -1,3 +1,26 @@
> +-># Copyright (C) 2025-2026 Free Software Foundation, Inc.
> +-># This program is free software; you can redistribute it and/or modify
> +-># it under the terms of the GNU General Public License as published by
> +-># the Free Software Foundation; either version 3 of the License, or
> +-># (at your option) any later version.
> +->#
> +-># This program is distributed in the hope that it will be useful,
> +-># but WITHOUT ANY WARRANTY; without even the implied warranty of
> +-># MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +-># GNU General Public License for more details.
> +->#
> +-># You should have received a copy of the GNU General Public License
> +-># along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +->#
> +-># Hack: comments are not supported in this file, so instead use a rule
> +-># rewriting an empty word.  This hack may stop working after a codespell
> +-># update.
> +->#
> +-># Note: empty lines are not supported either.
> +->#
> +-># I've filed an issue about these two problems [1].
> +->#
> +-># [1] https://github.com/codespell-project/codespell/issues/3901
>   gdbsever->gdbserver
>   tcllint->tclint
>   recordered->recorded
> diff --git a/gdb/contrib/codespell-ignore-words.txt b/gdb/contrib/codespell-ignore-words.txt
> index c07df0c001d..e9c1c2dc2f4 100644
> --- a/gdb/contrib/codespell-ignore-words.txt
> +++ b/gdb/contrib/codespell-ignore-words.txt
> @@ -1,3 +1,24 @@
> +# Copyright (C) 2025-2026 Free Software Foundation, Inc.
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +# Note: comments are not explicitly supported in this file [1], but using them
> +# doesn't seem to cause problems.
> +#
> +# Note: empty lines do seem to work here (unlike in codespell-dictionary.txt).
> +#
> +# [1] https://github.com/codespell-project/codespell/issues/2063
> +
>   configury
>   SME
>   Synopsys
> diff --git a/gdb/contrib/setup.cfg b/gdb/contrib/setup.cfg
> index 4793a6264af..3aa8ac058ab 100644
> --- a/gdb/contrib/setup.cfg
> +++ b/gdb/contrib/setup.cfg
> @@ -1,3 +1,17 @@
> +# Copyright (C) 2025-2026 Free Software Foundation, Inc.
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
>   [codespell]
>   
>   # Skip ChangeLogs and generated files.


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PING][PATCH 1/2] [gdb/contrib] Add missing copyright notices
  2026-04-10 12:30   ` [PING][PATCH " Tom de Vries
@ 2026-06-01 12:54     ` Tom de Vries
  0 siblings, 0 replies; 6+ messages in thread
From: Tom de Vries @ 2026-06-01 12:54 UTC (permalink / raw)
  To: gdb-patches

On 4/10/26 2:30 PM, Tom de Vries wrote:
> On 3/26/26 6:02 PM, Tom de Vries wrote:
>> I found a few files in gdb/contrib that were missing a copyright notice.
>>
>> In setup.cfg, it was trivial to add.
>>
>> In codespell-ignore-words.txt, it was also trivial to add, but I found a
>> codespell issue stating that it's not explicitly support, so I added a 
>> note
>> about that.
>>
>> In codespell-dictionary.txt, I had to resort to a hack, using an 
>> "empty word"
>> rewrite rule:
>> ...
>> -># Comment here.
>> ...
>>
>> Also, I found that empty lines are not allowed in codespell- 
>> dictionary.txt.  I
>> filed an issue about these two problems [1].
>>
>> Since these three files were added in 2025, I've used 2025-2026 as 
>> copyright
>> years.
>>
> 
> Ping.
> 

Now that gdb/contrib/setup.cfg is gone, I've dropped that part and 
rewritten the commit message accordingly.

I've asked Claude Code to review the patch.

It did comment on the fragility of the codespell-dictionary.txt hack, 
which I agree with, but I'm hoping this will be short lived, and if it 
turns out to cause problems, it's easy enough to revert.

Pushed.

Thanks,
- Tom

> Thanks,
> - Tom
> 
>> Tested by running "pre-commit run --all-files".
>>
>> [1] https://github.com/codespell-project/codespell/issues/3901
>> ---
>>   gdb/contrib/codespell-dictionary.txt   | 23 +++++++++++++++++++++++
>>   gdb/contrib/codespell-ignore-words.txt | 21 +++++++++++++++++++++
>>   gdb/contrib/setup.cfg                  | 14 ++++++++++++++
>>   3 files changed, 58 insertions(+)
>>
>> diff --git a/gdb/contrib/codespell-dictionary.txt b/gdb/contrib/ 
>> codespell-dictionary.txt
>> index 70914421cbf..b02e6eb1997 100644
>> --- a/gdb/contrib/codespell-dictionary.txt
>> +++ b/gdb/contrib/codespell-dictionary.txt
>> @@ -1,3 +1,26 @@
>> +-># Copyright (C) 2025-2026 Free Software Foundation, Inc.
>> +-># This program is free software; you can redistribute it and/or modify
>> +-># it under the terms of the GNU General Public License as published by
>> +-># the Free Software Foundation; either version 3 of the License, or
>> +-># (at your option) any later version.
>> +->#
>> +-># This program is distributed in the hope that it will be useful,
>> +-># but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +-># MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +-># GNU General Public License for more details.
>> +->#
>> +-># You should have received a copy of the GNU General Public License
>> +-># along with this program.  If not, see <http://www.gnu.org/ 
>> licenses/>.
>> +->#
>> +-># Hack: comments are not supported in this file, so instead use a rule
>> +-># rewriting an empty word.  This hack may stop working after a 
>> codespell
>> +-># update.
>> +->#
>> +-># Note: empty lines are not supported either.
>> +->#
>> +-># I've filed an issue about these two problems [1].
>> +->#
>> +-># [1] https://github.com/codespell-project/codespell/issues/3901
>>   gdbsever->gdbserver
>>   tcllint->tclint
>>   recordered->recorded
>> diff --git a/gdb/contrib/codespell-ignore-words.txt b/gdb/contrib/ 
>> codespell-ignore-words.txt
>> index c07df0c001d..e9c1c2dc2f4 100644
>> --- a/gdb/contrib/codespell-ignore-words.txt
>> +++ b/gdb/contrib/codespell-ignore-words.txt
>> @@ -1,3 +1,24 @@
>> +# Copyright (C) 2025-2026 Free Software Foundation, Inc.
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 3 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +#
>> +# Note: comments are not explicitly supported in this file [1], but 
>> using them
>> +# doesn't seem to cause problems.
>> +#
>> +# Note: empty lines do seem to work here (unlike in codespell- 
>> dictionary.txt).
>> +#
>> +# [1] https://github.com/codespell-project/codespell/issues/2063
>> +
>>   configury
>>   SME
>>   Synopsys
>> diff --git a/gdb/contrib/setup.cfg b/gdb/contrib/setup.cfg
>> index 4793a6264af..3aa8ac058ab 100644
>> --- a/gdb/contrib/setup.cfg
>> +++ b/gdb/contrib/setup.cfg
>> @@ -1,3 +1,17 @@
>> +# Copyright (C) 2025-2026 Free Software Foundation, Inc.
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 3 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +
>>   [codespell]
>>   # Skip ChangeLogs and generated files.
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-06-01 12:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-26 17:02 [PATCH 0/2] [gdb] Add missing copyright notices Tom de Vries
2026-03-26 17:02 ` [PATCH 1/2] [gdb/contrib] " Tom de Vries
2026-04-10 12:30   ` [PING][PATCH " Tom de Vries
2026-06-01 12:54     ` Tom de Vries
2026-03-26 17:02 ` [PATCH 2/2] [gdb] Add missing copyright notice in pyproject.toml Tom de Vries
2026-04-10 12:29   ` Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox