From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GeW4LROBHWrnmC0AWB0awg (envelope-from ) for ; Mon, 01 Jun 2026 08:54:43 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t/fPULgG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5aw0FXt7; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EmulMRH+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1/lobrjV; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A5F3A1E0A3; Mon, 01 Jun 2026 08:54:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A63881E062 for ; Mon, 01 Jun 2026 08:54:42 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0B1E4BA2E29 for ; Mon, 1 Jun 2026 12:54:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0B1E4BA2E29 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t/fPULgG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5aw0FXt7; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EmulMRH+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1/lobrjV Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id BA4044BA2E0D for ; Mon, 1 Jun 2026 12:54:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA4044BA2E0D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA4044BA2E0D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780318451; cv=none; b=eNRP30c+1cdzcSg5q0nh8UANzEQjzZ99D2KiwU/dnhiNkahr72nQt0s2QA2xG58G2LoUYEvTZrvgIngqOhc3hTGE8WU/Fj5oFgIN/yx+Q+kJnroBTb90lnjMVPlsikiBZwcXYidobAWkiwZlXJGV2l1gETNAaoeVSVI7kWFla44= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780318451; c=relaxed/simple; bh=FZqBGDBFkeFOMrBUyaTOfDsZ1j1F1bZIDQKJi6ao36A=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=i/rSRGnAC/UMkdKackkYrWU4PbVqKKSHwhH3ce2/4G21eWfzK838N8n4jy9ViAaK9hZGrOndNpBcFTzwhrglQ0NTUYTQDCUAhP8ICYhvqUReRnpPMDrVvdeh9hQvl3JR8gFuvblJQ5yWK9AK7d9YNTS13kN8GdwGKHeRrZcc674= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t/fPULgG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=5aw0FXt7; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=EmulMRH+; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1/lobrjV DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA4044BA2E0D Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 62F75682D5 for ; Mon, 1 Jun 2026 12:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780318450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F75DYFGI0OG5AuxYQnJCIxu3LcPL3X8P8+3NJWDFKcc=; b=t/fPULgGlSbUNIK6m1d/Y+mBY0rD7/z2maMKyedBQ+FYujNvkW61qoobofraRgzR8CHALK of/8343QjuEYM22tJev6jplOezeJQzIlx8eqWIet+q79WREM26FteQRhA1XeQDVoKYRGIM uf8dmtR4YF7DuAUkMzItPTI1VrTMjKk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780318450; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F75DYFGI0OG5AuxYQnJCIxu3LcPL3X8P8+3NJWDFKcc=; b=5aw0FXt7hHS5T+U4Hsr5ntaIrB7sepZNx8SeFtGYDWl0KlR1T0KPw7njIksPcrYU6lwhmb pGaOG93B6eko9EBQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=EmulMRH+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="1/lobrjV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1780318449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F75DYFGI0OG5AuxYQnJCIxu3LcPL3X8P8+3NJWDFKcc=; b=EmulMRH+Dvdr+kyKpDxRKu76RzOw3W+rZIz+i6KiqrodPkNloPXvKTsoKYTxE/ibg6qc8U Kc2zFoZMQT69wWlJCRI87S/Efs/mNghmMF+dVfGRmK8BTuBOMEPjqXoq4rSPz95i2k8Y9R t0X90iffrMOTwOHnqyTnME+YP0wavrA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1780318449; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F75DYFGI0OG5AuxYQnJCIxu3LcPL3X8P8+3NJWDFKcc=; b=1/lobrjVy5bhYxa0sNYhT5jTLYEefT3nuFahFY3+8f5qN3NeMN1XZpbzyCssMdCABe2Avl 6xFWeFlYR3/x9DDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 52B87779A7 for ; Mon, 1 Jun 2026 12:54:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Ahb6EvGAHWpaIAAAD6G6ig (envelope-from ) for ; Mon, 01 Jun 2026 12:54:09 +0000 Message-ID: Date: Mon, 1 Jun 2026 14:54:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH 1/2] [gdb/contrib] Add missing copyright notices From: Tom de Vries To: gdb-patches@sourceware.org References: <20260326170248.218742-1-tdevries@suse.de> <20260326170248.218742-2-tdevries@suse.de> <56027fa2-1a3a-496d-9efa-7c1821579b79@suse.de> Content-Language: en-US In-Reply-To: <56027fa2-1a3a-496d-9efa-7c1821579b79@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: 62F75682D5 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; DBL_BLOCKED_OPENRESOLVER(0.00)[gnu.org:url,suse.de:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; RCVD_TLS_ALL(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/10/26 2:30 PM, Tom de Vries wrote: > On 3/26/26 6:02 PM, Tom de Vries wrote: >> I found a few files in gdb/contrib that were missing a copyright notice. >> >> In setup.cfg, it was trivial to add. >> >> In codespell-ignore-words.txt, it was also trivial to add, but I found a >> codespell issue stating that it's not explicitly support, so I added a >> note >> about that. >> >> In codespell-dictionary.txt, I had to resort to a hack, using an >> "empty word" >> rewrite rule: >> ... >> -># Comment here. >> ... >> >> Also, I found that empty lines are not allowed in codespell- >> dictionary.txt.  I >> filed an issue about these two problems [1]. >> >> Since these three files were added in 2025, I've used 2025-2026 as >> copyright >> years. >> > > Ping. > Now that gdb/contrib/setup.cfg is gone, I've dropped that part and rewritten the commit message accordingly. I've asked Claude Code to review the patch. It did comment on the fragility of the codespell-dictionary.txt hack, which I agree with, but I'm hoping this will be short lived, and if it turns out to cause problems, it's easy enough to revert. Pushed. Thanks, - Tom > Thanks, > - Tom > >> Tested by running "pre-commit run --all-files". >> >> [1] https://github.com/codespell-project/codespell/issues/3901 >> --- >>   gdb/contrib/codespell-dictionary.txt   | 23 +++++++++++++++++++++++ >>   gdb/contrib/codespell-ignore-words.txt | 21 +++++++++++++++++++++ >>   gdb/contrib/setup.cfg                  | 14 ++++++++++++++ >>   3 files changed, 58 insertions(+) >> >> diff --git a/gdb/contrib/codespell-dictionary.txt b/gdb/contrib/ >> codespell-dictionary.txt >> index 70914421cbf..b02e6eb1997 100644 >> --- a/gdb/contrib/codespell-dictionary.txt >> +++ b/gdb/contrib/codespell-dictionary.txt >> @@ -1,3 +1,26 @@ >> +-># Copyright (C) 2025-2026 Free Software Foundation, Inc. >> +-># This program is free software; you can redistribute it and/or modify >> +-># it under the terms of the GNU General Public License as published by >> +-># the Free Software Foundation; either version 3 of the License, or >> +-># (at your option) any later version. >> +-># >> +-># This program is distributed in the hope that it will be useful, >> +-># but WITHOUT ANY WARRANTY; without even the implied warranty of >> +-># MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the >> +-># GNU General Public License for more details. >> +-># >> +-># You should have received a copy of the GNU General Public License >> +-># along with this program.  If not, see > licenses/>. >> +-># >> +-># Hack: comments are not supported in this file, so instead use a rule >> +-># rewriting an empty word.  This hack may stop working after a >> codespell >> +-># update. >> +-># >> +-># Note: empty lines are not supported either. >> +-># >> +-># I've filed an issue about these two problems [1]. >> +-># >> +-># [1] https://github.com/codespell-project/codespell/issues/3901 >>   gdbsever->gdbserver >>   tcllint->tclint >>   recordered->recorded >> diff --git a/gdb/contrib/codespell-ignore-words.txt b/gdb/contrib/ >> codespell-ignore-words.txt >> index c07df0c001d..e9c1c2dc2f4 100644 >> --- a/gdb/contrib/codespell-ignore-words.txt >> +++ b/gdb/contrib/codespell-ignore-words.txt >> @@ -1,3 +1,24 @@ >> +# Copyright (C) 2025-2026 Free Software Foundation, Inc. >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program.  If not, see . >> +# >> +# Note: comments are not explicitly supported in this file [1], but >> using them >> +# doesn't seem to cause problems. >> +# >> +# Note: empty lines do seem to work here (unlike in codespell- >> dictionary.txt). >> +# >> +# [1] https://github.com/codespell-project/codespell/issues/2063 >> + >>   configury >>   SME >>   Synopsys >> diff --git a/gdb/contrib/setup.cfg b/gdb/contrib/setup.cfg >> index 4793a6264af..3aa8ac058ab 100644 >> --- a/gdb/contrib/setup.cfg >> +++ b/gdb/contrib/setup.cfg >> @@ -1,3 +1,17 @@ >> +# Copyright (C) 2025-2026 Free Software Foundation, Inc. >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program.  If not, see . >> + >>   [codespell] >>   # Skip ChangeLogs and generated files. >