Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PING][PATCH 1/2] [gdb/contrib] Add missing copyright notices
Date: Fri, 10 Apr 2026 14:30:32 +0200	[thread overview]
Message-ID: <56027fa2-1a3a-496d-9efa-7c1821579b79@suse.de> (raw)
In-Reply-To: <20260326170248.218742-2-tdevries@suse.de>

On 3/26/26 6:02 PM, Tom de Vries wrote:
> I found a few files in gdb/contrib that were missing a copyright notice.
> 
> In setup.cfg, it was trivial to add.
> 
> In codespell-ignore-words.txt, it was also trivial to add, but I found a
> codespell issue stating that it's not explicitly support, so I added a note
> about that.
> 
> In codespell-dictionary.txt, I had to resort to a hack, using an "empty word"
> rewrite rule:
> ...
> -># Comment here.
> ...
> 
> Also, I found that empty lines are not allowed in codespell-dictionary.txt.  I
> filed an issue about these two problems [1].
> 
> Since these three files were added in 2025, I've used 2025-2026 as copyright
> years.
> 

Ping.

Thanks,
- Tom

> Tested by running "pre-commit run --all-files".
> 
> [1] https://github.com/codespell-project/codespell/issues/3901
> ---
>   gdb/contrib/codespell-dictionary.txt   | 23 +++++++++++++++++++++++
>   gdb/contrib/codespell-ignore-words.txt | 21 +++++++++++++++++++++
>   gdb/contrib/setup.cfg                  | 14 ++++++++++++++
>   3 files changed, 58 insertions(+)
> 
> diff --git a/gdb/contrib/codespell-dictionary.txt b/gdb/contrib/codespell-dictionary.txt
> index 70914421cbf..b02e6eb1997 100644
> --- a/gdb/contrib/codespell-dictionary.txt
> +++ b/gdb/contrib/codespell-dictionary.txt
> @@ -1,3 +1,26 @@
> +-># Copyright (C) 2025-2026 Free Software Foundation, Inc.
> +-># This program is free software; you can redistribute it and/or modify
> +-># it under the terms of the GNU General Public License as published by
> +-># the Free Software Foundation; either version 3 of the License, or
> +-># (at your option) any later version.
> +->#
> +-># This program is distributed in the hope that it will be useful,
> +-># but WITHOUT ANY WARRANTY; without even the implied warranty of
> +-># MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +-># GNU General Public License for more details.
> +->#
> +-># You should have received a copy of the GNU General Public License
> +-># along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +->#
> +-># Hack: comments are not supported in this file, so instead use a rule
> +-># rewriting an empty word.  This hack may stop working after a codespell
> +-># update.
> +->#
> +-># Note: empty lines are not supported either.
> +->#
> +-># I've filed an issue about these two problems [1].
> +->#
> +-># [1] https://github.com/codespell-project/codespell/issues/3901
>   gdbsever->gdbserver
>   tcllint->tclint
>   recordered->recorded
> diff --git a/gdb/contrib/codespell-ignore-words.txt b/gdb/contrib/codespell-ignore-words.txt
> index c07df0c001d..e9c1c2dc2f4 100644
> --- a/gdb/contrib/codespell-ignore-words.txt
> +++ b/gdb/contrib/codespell-ignore-words.txt
> @@ -1,3 +1,24 @@
> +# Copyright (C) 2025-2026 Free Software Foundation, Inc.
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +#
> +# Note: comments are not explicitly supported in this file [1], but using them
> +# doesn't seem to cause problems.
> +#
> +# Note: empty lines do seem to work here (unlike in codespell-dictionary.txt).
> +#
> +# [1] https://github.com/codespell-project/codespell/issues/2063
> +
>   configury
>   SME
>   Synopsys
> diff --git a/gdb/contrib/setup.cfg b/gdb/contrib/setup.cfg
> index 4793a6264af..3aa8ac058ab 100644
> --- a/gdb/contrib/setup.cfg
> +++ b/gdb/contrib/setup.cfg
> @@ -1,3 +1,17 @@
> +# Copyright (C) 2025-2026 Free Software Foundation, Inc.
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
>   [codespell]
>   
>   # Skip ChangeLogs and generated files.


  reply	other threads:[~2026-04-10 12:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26 17:02 [PATCH 0/2] [gdb] " Tom de Vries
2026-03-26 17:02 ` [PATCH 1/2] [gdb/contrib] " Tom de Vries
2026-04-10 12:30   ` Tom de Vries [this message]
2026-06-01 12:54     ` [PING][PATCH " Tom de Vries
2026-03-26 17:02 ` [PATCH 2/2] [gdb] Add missing copyright notice in pyproject.toml Tom de Vries
2026-04-10 12:29   ` Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56027fa2-1a3a-496d-9efa-7c1821579b79@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox