Re: [PATCH 0/3] Minor cleanups in disassemble code

[John Baldwin <jhb@FreeBSD.org>]

On 3/21/24 11:10 AM, Tom Tromey wrote:
> I happened to look at the disassemble code today, and I saw a few
> minor changes that, IMO, make it a bit cleaner.
> 
> Regression tested on x86-64 Fedora 38.
> 
> ---
> Tom Tromey (3):
>        Constify get_disassembler_options
>        Remove some unnecessary casts
>        Use std::string for disassembler options
> 
>   gdb/arc-tdep.c            | 15 +++++++--------
>   gdb/arch-utils.c          |  6 +++---
>   gdb/arm-tdep.c            |  6 +++---
>   gdb/disasm.c              | 22 +++++++++-------------
>   gdb/disasm.h              |  2 +-
>   gdb/gdbarch-gen.h         |  4 ++--
>   gdb/gdbarch.c             |  6 +++---
>   gdb/gdbarch_components.py |  2 +-
>   gdb/mips-tdep.c           | 14 +++++++-------
>   gdb/riscv-tdep.c          |  2 +-
>   gdb/rs6000-tdep.c         |  2 +-
>   gdb/s390-tdep.c           |  2 +-
>   12 files changed, 39 insertions(+), 44 deletions(-)
> ---
> base-commit: acaf48b921453c37fc2df4151699c912940bcd25
> change-id: 20240321-disassemble-cleanup-5da01a245e74
> 
> Best regards,

These all seem sensible.  It seems a bit odd to me that
gdbarch_disassembler_options returns a pointer to the string rather
than the string, but that was true before and not related to your
changes.

Approved-By: John Baldwin <jhb@FreeBSD.org>

-- 
John Baldwin