From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 04m9LQ7H/WVEzBEAWB0awg (envelope-from ) for ; Fri, 22 Mar 2024 13:59:42 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=TYLo374A; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AB3BC1E0C0; Fri, 22 Mar 2024 13:59:42 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3ACD91E08C for ; Fri, 22 Mar 2024 13:59:40 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E427F3858410 for ; Fri, 22 Mar 2024 17:59:39 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id 143673858D1E for ; Fri, 22 Mar 2024 17:59:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 143673858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 143673858D1E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2610:1c1:1:606c::19:2 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711130361; cv=pass; b=GH0L3GnPq1n5l5JeaBJ2/1FIDetOs8oOiXIew+nUiiiYtUEcWkTv59Q6WPoLznA5wH30jY4DJBs4SeKzbjzGjMhyiFSnQSu2BOc5nWon/RAbMn/qb/7ilIeCYiUOmt4JRnsWBMDPBOyEqgiSvpKAb1Jb8irttcdAqSd+Ng5Nsas= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1711130361; c=relaxed/simple; bh=Z1vTNVk374FWySDUDA6DcuFT3XsYqqy0J8TwSv5277s=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=B+0lRWfduwN7WAvF0DtztxHbIBQeFX7Mg7v/kSsCrM5biFvx1PrZ/WrXRHDcn1g5U8mG2iJyPaxTOTMxKNunyG9wcewqoeIywT3uOwI6/Stcra3f5rDd0fe0wTUfwyshWEAYLOI4a51sHfwTUCfRUhiaLsu5m9NAWNn1qIiMbEI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4V1VSq2vWWz3h79; Fri, 22 Mar 2024 17:59:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V1VSq1sWNz4mQj; Fri, 22 Mar 2024 17:59:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711130347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R3CC4feLIC7GGth8nIecki1x8fMtmBYVToE8Fsa+zcA=; b=TYLo374APyUMgvEh/E77dbR475bnOmMtTmJMZw+F5KHc9Dv01UabkOrRa0uNp2NSBmPSbE lMU/yv9kzpRULJb26MhE8nzAOz+TRZQ9lhD8z7KQa7Hu8rlGgaDJTe7cR2CLI/AR0/iHq4 vNiAhMOVf3B3bqnsaQbG/2vy2gzpIFa+RAF/nXPFg2KaPBZrCUDUgxC1IGHwmJOuUMDZIT ujOKNHr84OFUcDWB79Usj3F0q/DGQioQV2zKephftiXhMNoeW2ZY3PPExU/iBgHhkAsHfm UKSbsUzUjrs5qJ5dg4fa3+Krct7pf8DTLbSuge07OZr9gSWgNuKNZqOdUopWAQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711130347; a=rsa-sha256; cv=none; b=IB9AAwdfsxcRqUEpW94J2yajQhPePzTQ9entqejsz2UJ7kTXhiRHHyo0kkbMiMU6a8q/dy eun4YPNnVZE9qtxwgp19nuVl+1sn45alDvQikIi4ZP4Syzk4fZi10cPxvsjB2atzWQrvHm c6C/rV6kX5tIYulBflrTyX8+LAOdaO7Bygo/JPonFlUnQ1L1qEqp1xOllPFGXWHSuj2oh4 n1FWdh1MJ/OkBDjsJrlDciiHbS7tslsTE23Hu/6Q3o73xoNtAg9WJRDz3FYN7dV+ueE6qT DJjiXpp/Fw30SihrMaYX06ha3ndA1PQBqMCDpSG2AGvZxO+ofk1I73zugANpyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711130347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R3CC4feLIC7GGth8nIecki1x8fMtmBYVToE8Fsa+zcA=; b=jIFQB9uvfjAYvR45cKBcwXCZOERGbvEFX8x2+eBYHhwtO+OpNlWM0fzmKr0wupZJwd4LMD /bLyloLlcsh0A09Zb2oVD1SEt01EcbYxdHBLiYhEfyv1bODvSUYzjZJGrlwxKJ70ejJXnv OCglxEFGyqT1tgeinM16tpL1ybclybzk7tvZu01Wj1ZHsF2m1A8PWPdyx/ukqXrSi+8X6d h69Uoi1CjJK2+HQsj08EWElErryTqqum7TB81VXX7Vrag+QOYjOz1Ow+aQ7XoWKZRXlO8Z JeepnEyX40evimPgGSflrz9k8jypvFpc3eEJ6K65tHh/JimSMdp7aSmWJpvDKw== Received: from [IPV6:2601:644:937f:4c50:8511:5903:3902:6538] (unknown [IPv6:2601:644:937f:4c50:8511:5903:3902:6538]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V1VSp6gv9z1Z1D; Fri, 22 Mar 2024 17:59:06 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 22 Mar 2024 10:59:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] Minor cleanups in disassemble code Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240321-disassemble-cleanup-v1-0-77448506f4ab@adacore.com> From: John Baldwin In-Reply-To: <20240321-disassemble-cleanup-v1-0-77448506f4ab@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/21/24 11:10 AM, Tom Tromey wrote: > I happened to look at the disassemble code today, and I saw a few > minor changes that, IMO, make it a bit cleaner. > > Regression tested on x86-64 Fedora 38. > > --- > Tom Tromey (3): > Constify get_disassembler_options > Remove some unnecessary casts > Use std::string for disassembler options > > gdb/arc-tdep.c | 15 +++++++-------- > gdb/arch-utils.c | 6 +++--- > gdb/arm-tdep.c | 6 +++--- > gdb/disasm.c | 22 +++++++++------------- > gdb/disasm.h | 2 +- > gdb/gdbarch-gen.h | 4 ++-- > gdb/gdbarch.c | 6 +++--- > gdb/gdbarch_components.py | 2 +- > gdb/mips-tdep.c | 14 +++++++------- > gdb/riscv-tdep.c | 2 +- > gdb/rs6000-tdep.c | 2 +- > gdb/s390-tdep.c | 2 +- > 12 files changed, 39 insertions(+), 44 deletions(-) > --- > base-commit: acaf48b921453c37fc2df4151699c912940bcd25 > change-id: 20240321-disassemble-cleanup-5da01a245e74 > > Best regards, These all seem sensible. It seems a bit odd to me that gdbarch_disassembler_options returns a pointer to the string rather than the string, but that was true before and not related to your changes. Approved-By: John Baldwin -- John Baldwin