Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 2/3] Remove some unnecessary casts
Date: Thu, 21 Mar 2024 12:10:33 -0600	[thread overview]
Message-ID: <20240321-disassemble-cleanup-v1-2-77448506f4ab@adacore.com> (raw)
In-Reply-To: <20240321-disassemble-cleanup-v1-0-77448506f4ab@adacore.com>

I found a few unnecessary casts when calling
set_gdbarch_disassembler_options_implicit.
---
 gdb/mips-tdep.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c
index 8339d2f1d4c..107d06191b4 100644
--- a/gdb/mips-tdep.c
+++ b/gdb/mips-tdep.c
@@ -8736,14 +8736,14 @@ mips_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches)
 
   set_gdbarch_print_insn (gdbarch, gdb_print_insn_mips);
   if (mips_abi == MIPS_ABI_N64)
-    set_gdbarch_disassembler_options_implicit
-      (gdbarch, (const char *) mips_disassembler_options_n64);
+    set_gdbarch_disassembler_options_implicit (gdbarch,
+					       mips_disassembler_options_n64);
   else if (mips_abi == MIPS_ABI_N32)
-    set_gdbarch_disassembler_options_implicit
-      (gdbarch, (const char *) mips_disassembler_options_n32);
+    set_gdbarch_disassembler_options_implicit (gdbarch,
+					       mips_disassembler_options_n32);
   else
-    set_gdbarch_disassembler_options_implicit
-      (gdbarch, (const char *) mips_disassembler_options_o32);
+    set_gdbarch_disassembler_options_implicit (gdbarch,
+					       mips_disassembler_options_o32);
   set_gdbarch_disassembler_options (gdbarch, &mips_disassembler_options);
   set_gdbarch_valid_disassembler_options (gdbarch,
 					  disassembler_options_mips ());

-- 
2.43.0


  parent reply	other threads:[~2024-03-21 18:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 18:10 [PATCH 0/3] Minor cleanups in disassemble code Tom Tromey
2024-03-21 18:10 ` [PATCH 1/3] Constify get_disassembler_options Tom Tromey
2024-03-21 18:10 ` Tom Tromey [this message]
2024-03-21 18:10 ` [PATCH 3/3] Use std::string for disassembler options Tom Tromey
2024-03-22 17:59 ` [PATCH 0/3] Minor cleanups in disassemble code John Baldwin
2024-03-22 19:12   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240321-disassemble-cleanup-v1-2-77448506f4ab@adacore.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox