From: Tom Tromey <tromey@adacore.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Minor cleanups in disassemble code
Date: Fri, 22 Mar 2024 13:12:22 -0600 [thread overview]
Message-ID: <87y1aacc89.fsf@tromey.com> (raw)
In-Reply-To: <b091afad-5232-4151-954e-2db67648d159@FreeBSD.org> (John Baldwin's message of "Fri, 22 Mar 2024 10:59:05 -0700")
>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
John> These all seem sensible. It seems a bit odd to me that
John> gdbarch_disassembler_options returns a pointer to the string rather
John> than the string, but that was true before and not related to your
John> changes.
I guess it's so it can be set and fetched with a single api, and so
there can be a default of not letting the user touch the options for an
arch. It is a little weird though now that you mention it. Like why
have globals. Cleanup for another day perhaps.
Tom
prev parent reply other threads:[~2024-03-22 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 18:10 Tom Tromey
2024-03-21 18:10 ` [PATCH 1/3] Constify get_disassembler_options Tom Tromey
2024-03-21 18:10 ` [PATCH 2/3] Remove some unnecessary casts Tom Tromey
2024-03-21 18:10 ` [PATCH 3/3] Use std::string for disassembler options Tom Tromey
2024-03-22 17:59 ` [PATCH 0/3] Minor cleanups in disassemble code John Baldwin
2024-03-22 19:12 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1aacc89.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox