From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id DvnaGTXY/WUy3REAWB0awg (envelope-from ) for ; Fri, 22 Mar 2024 15:12:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=Yxb42pNs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4C42F1E0C0; Fri, 22 Mar 2024 15:12:53 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1FD971E08C for ; Fri, 22 Mar 2024 15:12:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 973593858C35 for ; Fri, 22 Mar 2024 19:12:50 +0000 (GMT) Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 4896A3858D1E for ; Fri, 22 Mar 2024 19:12:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4896A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4896A3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711134754; cv=none; b=OJZtqHcLjeKkSLqp89PreDVU5IZep9x2vjQFJNvvVdpFNCEde8xDE73hhAOCchG9ehfcHUahFDlVL/ANntGUyNq8jt1er6NAMp/SGDb+WBxx0W0EblXWl9cerDcN96u3Q0C1zoASP+hiVtvNCsS5XLWxvA0D2YackIRS/3+UyLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711134754; c=relaxed/simple; bh=hlctNc7fMqp4AoLh1w1c2j6RXzo+trFXZppFGaMM9LU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=RBPb38NjNzue78/RWpcc3vT6jQtq5Vy2pANt7xh2FcR9XihQX9z3oqVsXbRu9WtF9f1mS5Z+BSIfLWzmV8OIXLYYm9KO1nLtVc2jkoJexQHxflzdJ1nzVCvCKLZyGPp4KsV3AQPM8+GG5vGegfaYN0u6YGR6KoziLCL1ZSPPyb8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-368713f2f23so4199145ab.3 for ; Fri, 22 Mar 2024 12:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1711134743; x=1711739543; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aa1ysdV9XrYcUkzgy8VeMpKgb36y6ohE8gWMUSoh2F4=; b=Yxb42pNsrnFuYt7vUp8Vrmw4I/OH66icFJVSn9fgb68zt4RY+C5ra28b61t1JT9W1k kUZEHSW1Q6mwN/0J2TCrGvoq3qCzc73WaPGe15qNJ9GcLIFEiJRwcZ0MREJCqFoeNFNT PN/Hdb28/j1uGZPCjSvcvlOSBahiQqOfFxcL6U1Afy4dkxwIiaLyH1FFu3b4wYnWeX+i /urL/PNMZsOTlT48CW6ILzgjajn60AKs0CM90NPKW3NQMa/EJxTTT9OI0zj5SHe1z6el MUlnfIoS3aDbhFsQS3gKbAlOvSS7iz7gz/vsT8+y4N8RBnIla/iOfYzxj3KGMt5JVHL5 SFGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134743; x=1711739543; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aa1ysdV9XrYcUkzgy8VeMpKgb36y6ohE8gWMUSoh2F4=; b=PPibcwF5NeF0SetACks3njPw12BBT3LmxXMTTtx5aL4d8u8Dx/6t7u9uCmQCdLH7TR /0YE/1YFKrVfpNMxgt4ovIWeuVDxN6FyPQ9+9SMLwhQgtdoyfgl99YvFHtRjTs2H1QDr DCMtLO3zDBT+i51726NQkB9RQzMwGoHEWg+AiMiG3I/nviztT2oCfRX6xuyxSi7UrOtq +eYSQrLThErVkQ+Cxa2NQIiRzTEIYSM/94A/O0+0BSS33gWCDvjZ7OnWnOxrBI16RZTg d/XFpAmOwYY5uPtSc0P/9TDj0vgb7KM8FIgL+132a93g1TbwYLU446yXtUP3Y1D5fZSc V6Lg== X-Forwarded-Encrypted: i=1; AJvYcCUuWqAavI5TizX10t63hj/TTETYREUOENnLJxeKxIzOLkkhESoNg0X+OaiUqJ+DrvSkrHbrz4zo9rRgROkSstH07wPlcLsCQBgHqQ== X-Gm-Message-State: AOJu0YzcGWxuGJwp0PKDyZURExn9obJ5FbnATOC8bYDtFoswQGJSYCGq KpNK+mK/2hC34W+h+vVYTDK3E0YZ6dSI3TjfwY5gC2V3+j9HCuk0hYOVhQr73g== X-Google-Smtp-Source: AGHT+IGXNs9W8F5pqosl5kUgA5+HtBo6mrpLM5VYdXXylIChUGxNpd6jrozDJOCoJ1Iozv4WxcHPFw== X-Received: by 2002:a05:6e02:174d:b0:368:6187:e19a with SMTP id y13-20020a056e02174d00b003686187e19amr542636ill.3.1711134743454; Fri, 22 Mar 2024 12:12:23 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id w5-20020a92db45000000b00366755974e8sm742188ilq.22.2024.03.22.12.12.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 12:12:23 -0700 (PDT) From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Minor cleanups in disassemble code References: <20240321-disassemble-cleanup-v1-0-77448506f4ab@adacore.com> X-Attribution: Tom Date: Fri, 22 Mar 2024 13:12:22 -0600 In-Reply-To: (John Baldwin's message of "Fri, 22 Mar 2024 10:59:05 -0700") Message-ID: <87y1aacc89.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "John" == John Baldwin writes: John> These all seem sensible. It seems a bit odd to me that John> gdbarch_disassembler_options returns a pointer to the string rather John> than the string, but that was true before and not related to your John> changes. I guess it's so it can be set and fetched with a single api, and so there can be a default of not letting the user touch the options for an arch. It is a little weird though now that you mention it. Like why have globals. Cleanup for another day perhaps. Tom