From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Mike Frysinger <vapier@gentoo.org>,
Faraz Shahbazker <fshahbazker@wavecomp.com>
Cc: gdb-patches@sourceware.org, Chao-ying Fu <cfu@wavecomp.com>
Subject: Re: [PATCH v3] sim: mips: Add handlers to simulator monitor for unlink, lseek and stat
Date: Fri, 2 Apr 2021 22:36:30 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2104022227100.18977@angie.orcam.me.uk> (raw)
In-Reply-To: <YGUw8mucWJM9OAWU@vapier>
On Wed, 31 Mar 2021, Mike Frysinger wrote:
> lgtm! not sure if Maciej wants to take a pass.
It's not an area I am familiar with, so I've merely skimmed over only to
find a couple of very minor style consistency issues. Which I'll turn my
blind eye to on this occasion, so I'm fine with this change as it stands.
BTW, Faraz, good to see you're still onboard!
Maciej
next prev parent reply other threads:[~2021-04-02 20:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 9:32 [PATCH] " Faraz Shahbazker
2021-03-28 14:20 ` Faraz Shahbazker
2021-03-28 14:54 ` Mike Frysinger via Gdb-patches
2021-03-30 21:20 ` [EXTERNAL]Re: " Faraz Shahbazker
2021-03-31 2:17 ` Mike Frysinger via Gdb-patches
2021-03-30 21:21 ` [PATCH v1] " Faraz Shahbazker
2021-03-31 2:19 ` Mike Frysinger via Gdb-patches
2021-03-31 7:10 ` [PATCH v3] " Faraz Shahbazker
2021-04-01 2:33 ` Mike Frysinger via Gdb-patches
2021-04-02 20:36 ` Maciej W. Rozycki [this message]
2021-03-30 21:40 ` [PATCH v2] " Faraz Shahbazker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2104022227100.18977@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=cfu@wavecomp.com \
--cc=fshahbazker@wavecomp.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox