From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-bounces@sourceware.org>
Received: from simark.ca
	by simark.ca with LMTP
	id ZcM9LVOAZ2AtWQAAWB0awg
	(envelope-from <gdb-patches-bounces@sourceware.org>)
	for <public-inbox@simark.ca>; Fri, 02 Apr 2021 16:36:35 -0400
Received: by simark.ca (Postfix, from userid 112)
	id AB4871EF62; Fri,  2 Apr 2021 16:36:35 -0400 (EDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca
X-Spam-Level: 
X-Spam-Status: No, score=-0.6 required=5.0 tests=MAILING_LIST_MULTI,
	RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.2
Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by simark.ca (Postfix) with ESMTPS id DFDA31EE0E
	for <public-inbox@simark.ca>; Fri,  2 Apr 2021 16:36:34 -0400 (EDT)
Received: from server2.sourceware.org (localhost [IPv6:::1])
	by sourceware.org (Postfix) with ESMTP id 42EF9388A411;
	Fri,  2 Apr 2021 20:36:34 +0000 (GMT)
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::4])
 by sourceware.org (Postfix) with ESMTP id B3F51385E019
 for <gdb-patches@sourceware.org>; Fri,  2 Apr 2021 20:36:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B3F51385E019
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org;
 spf=none smtp.mailfrom=macro@orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
 id 60CD392009C; Fri,  2 Apr 2021 22:36:30 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
 by angie.orcam.me.uk (Postfix) with ESMTP id 5CDF392009B;
 Fri,  2 Apr 2021 22:36:30 +0200 (CEST)
Date: Fri, 2 Apr 2021 22:36:30 +0200 (CEST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Mike Frysinger <vapier@gentoo.org>, 
 Faraz Shahbazker <fshahbazker@wavecomp.com>
Subject: Re: [PATCH v3] sim: mips: Add handlers to simulator monitor for
 unlink, lseek and stat
In-Reply-To: <YGUw8mucWJM9OAWU@vapier>
Message-ID: <alpine.DEB.2.21.2104022227100.18977@angie.orcam.me.uk>
References: <YGPcM+tJcP+jWPWX@vapier>
 <20210331071049.1448914-1-fshahbazker@wavecomp.com> <YGUw8mucWJM9OAWU@vapier>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
Cc: gdb-patches@sourceware.org, Chao-ying Fu <cfu@wavecomp.com>
Errors-To: gdb-patches-bounces@sourceware.org
Sender: "Gdb-patches" <gdb-patches-bounces@sourceware.org>

On Wed, 31 Mar 2021, Mike Frysinger wrote:

> lgtm!  not sure if Maciej wants to take a pass.

 It's not an area I am familiar with, so I've merely skimmed over only to 
find a couple of very minor style consistency issues.  Which I'll turn my 
blind eye to on this occasion, so I'm fine with this change as it stands.

 BTW, Faraz, good to see you're still onboard!

  Maciej