Re: [PATCH] sim: mips: Add handlers to simulator monitor for unlink, lseek and stat

[Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>]

On 28 Mar 2021 02:32, Faraz Shahbazker wrote:
> sim/mips/ChangeLog
> 	* interp.c (sim_monitor): Add switch entries for unlink (13),
> 	lseek (14), and stat (15).

what ABI is sim_monitor supposed to be supporting ?  it seems to be confused
between IDT monitor & PMON, or at least out of sync with the libgloss code.

it would be nice if this were cleaned up to define the ABIs using constant
maps.  cris/traps.c is one example.

> +#include <byteswap.h>

this is not portable.  we have sim-endian.h APIs already you should use.

> +    case 15: /* int stat(const char *path, struct stat *buf); */
> +      {
> +	/* We need to put the data into the type of stat structure
> +	   that MIPS uses and make sure it has the correct endianness.
> +	   We are assuming that the host and MIPS agree on what the bits
> +	   in st_mode mean.  That appears to be true for x86 linux and
> +	   MIPS.  */
> +	struct stat host_stat;
> +	struct __attribute__ ((__packed__)) mips_stat {
> +	  short st_dev;
> +	  unsigned short st_ino;
> +	  unsigned int st_mode;
> +	  unsigned short st_nlink;
> +	  unsigned short st_uid;
> +	  unsigned short st_gid;
> +	  short st_rdev;
> +	  union {
> +	    int b32;
> +	    long b64;
> +	  } st_size;
> +	} mips_stat;

the sim core provides APIs to automate this.  grep for "stat_map" in the bfin,
cris, and common code.
-mike