From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Faraz Shahbazker <fshahbazker@wavecomp.com>
Cc: gdb-patches@sourceware.org, Chao-ying Fu <cfu@wavecomp.com>
Subject: Re: [PATCH v1] sim: mips: Add handlers to simulator monitor for unlink, lseek and stat
Date: Tue, 30 Mar 2021 22:19:31 -0400 [thread overview]
Message-ID: <YGPcM+tJcP+jWPWX@vapier> (raw)
In-Reply-To: <20210330212109.676809-1-fshahbazker@wavecomp.com>
On 31 Mar 2021 02:51, Faraz Shahbazker wrote:
> sim/mips/ChangeLog
> * interp.c (sim_monitor): Add switch entries for unlink (13),
> lseek (14), and stat (15).
>
> Derived from patch authored by Steve Ellcey <sellcey@mips.com>
mostly looks good. just one thing ...
> --- a/sim/mips/interp.c
> +++ b/sim/mips/interp.c
> + if (cb_syscall (cb, &s) != CB_RC_OK)
> + {
> + abort ();
> + sim_engine_halt (sd, cpu, NULL, mips_pc_get (cpu),
> + sim_stopped, SIM_SIGILL);
> + }
why the abort ? sim_engine_halt should be more than sufficient to throw an
error & shut everything down. abort will kill the process which is bad when
we're using the sim as a library embedded into another program/runtime.
-mike
next prev parent reply other threads:[~2021-03-31 2:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 9:32 [PATCH] " Faraz Shahbazker
2021-03-28 14:20 ` Faraz Shahbazker
2021-03-28 14:54 ` Mike Frysinger via Gdb-patches
2021-03-30 21:20 ` [EXTERNAL]Re: " Faraz Shahbazker
2021-03-31 2:17 ` Mike Frysinger via Gdb-patches
2021-03-30 21:21 ` [PATCH v1] " Faraz Shahbazker
2021-03-31 2:19 ` Mike Frysinger via Gdb-patches [this message]
2021-03-31 7:10 ` [PATCH v3] " Faraz Shahbazker
2021-04-01 2:33 ` Mike Frysinger via Gdb-patches
2021-04-02 20:36 ` Maciej W. Rozycki
2021-03-30 21:40 ` [PATCH v2] " Faraz Shahbazker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGPcM+tJcP+jWPWX@vapier \
--to=gdb-patches@sourceware.org \
--cc=cfu@wavecomp.com \
--cc=fshahbazker@wavecomp.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox