[PATCH] procfs.c: Include "filestuff.h"

[PATCH] procfs.c: Include "filestuff.h"

[Marcin Cieslak]

Fixes implicit function declaration
error in procfs.c:4927 about undeclared
make_cleanup_close().

gdb/ChangeLog:

	PR gdb/18843
	* procfs.c: Include "filestuff.h"
---
 gdb/ChangeLog | 5 +++++
 gdb/procfs.c  | 1 +
 2 files changed, 6 insertions(+)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4af881e..edb4d88 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-08-18  Marcin CieÂślak <saper@saper.info>
+
+	PR gdb/18843
+	* procfs.c: Include "filestuff.h"
+
 2015-08-18  Sandra Loosemore  <sandra@codesourcery.com>
 
 	* remote.c (strprefix): New.
diff --git a/gdb/procfs.c b/gdb/procfs.c
index 42f1403..3d4f7be 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -30,6 +30,7 @@
 #include "gdbthread.h"
 #include "regcache.h"
 #include "inf-child.h"
+#include "filestuff.h"
 
 #if defined (NEW_PROC_API)
 #define _STRUCTURED_PROC 1	/* Should be done by configure script.  */
-- 
2.5.0

Re: [PATCH] procfs.c: Include "filestuff.h"

[Yao Qi]

Marcin Cieslak <saper@saper.info> writes:

> Fixes implicit function declaration
> error in procfs.c:4927 about undeclared
> make_cleanup_close().
>
> gdb/ChangeLog:
>
> 	PR gdb/18843

Nit: it should be "PR build/18843".

> 	* procfs.c: Include "filestuff.h"

It is a sentence so should be ended with ".".

Otherwise, patch is OK to me.  You can push it in or I can push it in in
case you don't have write access to git repository.

-- 
Yao (齐尧)

Re: [PATCH] procfs.c: Include "filestuff.h"

[Marcin Cieslak]

Fixes implicit function declaration
error in gdb/procfs.c:4927 about undeclared
make_cleanup_close().

gdb/ChangeLog:

	PR build/18843
	* procfs.c: Include "filestuff.h".
---
 gdb/ChangeLog |    5 +++++
 gdb/procfs.c  |    1 +
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4af881e..ec3519a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-08-18  Marcin CieÂślak <saper@saper.info>
+
+	PR build/18843
+	* procfs.c: Include "filestuff.h".
+
 2015-08-18  Sandra Loosemore  <sandra@codesourcery.com>
 
 	* remote.c (strprefix): New.
diff --git a/gdb/procfs.c b/gdb/procfs.c
index 42f1403..3d4f7be 100644
--- a/gdb/procfs.c
+++ b/gdb/procfs.c
@@ -30,6 +30,7 @@
 #include "gdbthread.h"
 #include "regcache.h"
 #include "inf-child.h"
+#include "filestuff.h"
 
 #if defined (NEW_PROC_API)
 #define _STRUCTURED_PROC 1	/* Should be done by configure script.  */
-- 
1.6.2.1

Re: [PATCH] procfs.c: Include "filestuff.h"

[Marcin Cieslak]

On Wed, 19 Aug 2015, Yao Qi wrote:

> Otherwise, patch is OK to me.  You can push it in or I can push it in in
> case you don't have write access to git repository.

Nits should be fixed. It is my first contribution to gdb ever,
so I doubt I have a write access anywhere :)

~Marcin 

Re: [PATCH] procfs.c: Include "filestuff.h"

[Yao Qi]

Marcin Cieslak <saper@saper.info> writes:

> Nits should be fixed. It is my first contribution to gdb ever,
> so I doubt I have a write access anywhere :)

Thanks.  I pushed your patch in to both master and 7.10 branch.

-- 
Yao (齐尧)