From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120374 invoked by alias); 19 Aug 2015 07:54:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120357 invoked by uid 89); 19 Aug 2015 07:54:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 19 Aug 2015 07:54:02 +0000 Received: by pawq9 with SMTP id q9so55204647paw.3 for ; Wed, 19 Aug 2015 00:54:00 -0700 (PDT) X-Received: by 10.68.232.104 with SMTP id tn8mr21922693pbc.155.1439970840287; Wed, 19 Aug 2015 00:54:00 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id rp12sm20508310pbb.65.2015.08.19.00.53.58 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 19 Aug 2015 00:53:59 -0700 (PDT) From: Yao Qi To: Marcin Cieslak Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] procfs.c: Include "filestuff.h" References: Date: Wed, 19 Aug 2015 07:54:00 -0000 In-Reply-To: (Marcin Cieslak's message of "Tue, 18 Aug 2015 18:07:54 +0000") Message-ID: <864mjv3e97.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-08/txt/msg00500.txt.bz2 Marcin Cieslak writes: > Fixes implicit function declaration > error in procfs.c:4927 about undeclared > make_cleanup_close(). > > gdb/ChangeLog: > > PR gdb/18843 Nit: it should be "PR build/18843". > * procfs.c: Include "filestuff.h" It is a sentence so should be ended with ".". Otherwise, patch is OK to me. You can push it in or I can push it in in case you don't have write access to git repository. --=20 Yao (=E9=BD=90=E5=B0=A7)