Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Marcin Cieslak <saper@saper.info>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] procfs.c: Include "filestuff.h"
Date: Wed, 19 Aug 2015 07:54:00 -0000	[thread overview]
Message-ID: <864mjv3e97.fsf@gmail.com> (raw)
In-Reply-To: <alpine.BSF.2.11.1508181807170.7491@z.fncre.vasb> (Marcin	Cieslak's message of "Tue, 18 Aug 2015 18:07:54 +0000")

Marcin Cieslak <saper@saper.info> writes:

> Fixes implicit function declaration
> error in procfs.c:4927 about undeclared
> make_cleanup_close().
>
> gdb/ChangeLog:
>
> 	PR gdb/18843

Nit: it should be "PR build/18843".

> 	* procfs.c: Include "filestuff.h"

It is a sentence so should be ended with ".".

Otherwise, patch is OK to me.  You can push it in or I can push it in in
case you don't have write access to git repository.

-- 
Yao (齐尧)


  reply	other threads:[~2015-08-19  7:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-18 18:08 Marcin Cieslak
2015-08-19  7:54 ` Yao Qi [this message]
2015-08-19 16:51   ` Marcin Cieslak
2015-08-19 16:52   ` Marcin Cieslak
2015-08-21  8:21     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864mjv3e97.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=saper@saper.info \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox