From: Keith Seitz <keiths@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] compile: Remove non-const reference parameters
Date: Thu, 30 Aug 2018 21:57:00 -0000 [thread overview]
Message-ID: <aa53c53e-c6dc-73d1-60da-c8e854f15aa8@redhat.com> (raw)
In-Reply-To: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com>
On 08/30/2018 09:47 AM, Simon Marchi wrote:
>
> I'd say all the changes are pretty obvious, except the one in
> compile_cplus_instance::enter_scope which might require more attention.
That scope-handling code is a little bit of a mess, given that it was written,
and then rewritten, right as we were moving from C -> C++03 -> C++11. So I
had no access to unique_ptrs.
Nonetheless, the intent is that a scope is created and control of that object
is then handed over to the compile_cplus_instance entirely. So your patch
LGTM.
With access to C++11 that we enjoy today, I might have written this
interface quite a bit differently...
Keith
next prev parent reply other threads:[~2018-08-30 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 16:47 Simon Marchi
2018-08-30 21:57 ` Keith Seitz [this message]
2018-08-31 14:41 ` Tom Tromey
2018-09-06 10:27 ` Simon Marchi
2018-09-06 12:43 ` Tom Tromey
2018-09-06 12:49 ` Simon Marchi
2018-09-17 6:32 ` Tom Tromey
2018-09-17 13:29 ` Keith Seitz
2018-09-17 13:52 ` [PATCH] Fix use-after-move in compile/compile-cplus-types.c Simon Marchi
2018-09-17 15:25 ` Keith Seitz
2018-09-17 17:10 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa53c53e-c6dc-73d1-60da-c8e854f15aa8@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox