From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88304 invoked by alias); 30 Aug 2018 21:57:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88294 invoked by uid 89); 30 Aug 2018 21:57:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:701, entirely X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 30 Aug 2018 21:57:16 +0000 Received: from smtp.corp.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 34E793B98; Thu, 30 Aug 2018 21:57:15 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3CA9B898A; Thu, 30 Aug 2018 21:57:14 +0000 (UTC) Subject: Re: [PATCH] compile: Remove non-const reference parameters To: Simon Marchi , gdb-patches@sourceware.org References: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> From: Keith Seitz Message-ID: Date: Thu, 30 Aug 2018 21:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00846.txt.bz2 On 08/30/2018 09:47 AM, Simon Marchi wrote: > > I'd say all the changes are pretty obvious, except the one in > compile_cplus_instance::enter_scope which might require more attention. That scope-handling code is a little bit of a mess, given that it was written, and then rewritten, right as we were moving from C -> C++03 -> C++11. So I had no access to unique_ptrs. Nonetheless, the intent is that a scope is created and control of that object is then handed over to the compile_cplus_instance entirely. So your patch LGTM. With access to C++11 that we enjoy today, I might have written this interface quite a bit differently... Keith