Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tom@tromey.com>, Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] compile: Remove non-const reference parameters
Date: Mon, 17 Sep 2018 13:29:00 -0000	[thread overview]
Message-ID: <82a8995b-fd73-ad0b-ed82-64cdb0b54272@redhat.com> (raw)
In-Reply-To: <874leoocso.fsf@tromey.com>

On 09/16/2018 11:31 PM, Tom Tromey wrote:
> I think this particular change introduced a regression.  runtest
> gdb.compile/*.exp causes gdb to crash for me several times on x86-64
> Fedora 28.

Fedora 28 is really broken right now. I have patches to fix almost
everything*, but I am struggling to understand why one of them is needed.
AFAICT, either __builtin_memcpy has usage changes that I missed, or there is
a glibc bug here. ["compile print" is completely broken -- the
__builtin_memcpy on Fedora 28 does nothing. Works fine on my Fedora 21
and 26 boxes.]

Using __builtin_memmove works fine, though. [And just to state the obvious,
no, the memory regions do not overlap.]

Keith

* "Everything" = everything except what appears to be a newly introduced GCC
8 bug that causes regressions in compile-cplus-method.exp.


  reply	other threads:[~2018-09-17 13:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 16:47 Simon Marchi
2018-08-30 21:57 ` Keith Seitz
2018-08-31 14:41   ` Tom Tromey
2018-09-06 10:27     ` Simon Marchi
2018-09-06 12:43       ` Tom Tromey
2018-09-06 12:49         ` Simon Marchi
2018-09-17  6:32 ` Tom Tromey
2018-09-17 13:29   ` Keith Seitz [this message]
2018-09-17 13:52     ` [PATCH] Fix use-after-move in compile/compile-cplus-types.c Simon Marchi
2018-09-17 15:25       ` Keith Seitz
2018-09-17 17:10         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82a8995b-fd73-ad0b-ed82-64cdb0b54272@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox