From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83505 invoked by alias); 17 Sep 2018 13:29:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83135 invoked by uid 89); 17 Sep 2018 13:29:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=boxes X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 13:29:15 +0000 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2FB5785540; Mon, 17 Sep 2018 13:29:14 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA3BF308BDA0; Mon, 17 Sep 2018 13:29:13 +0000 (UTC) Subject: Re: [PATCH] compile: Remove non-const reference parameters To: Tom Tromey , Simon Marchi Cc: gdb-patches@sourceware.org References: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> <874leoocso.fsf@tromey.com> From: Keith Seitz Message-ID: <82a8995b-fd73-ad0b-ed82-64cdb0b54272@redhat.com> Date: Mon, 17 Sep 2018 13:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <874leoocso.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00571.txt.bz2 On 09/16/2018 11:31 PM, Tom Tromey wrote: > I think this particular change introduced a regression. runtest > gdb.compile/*.exp causes gdb to crash for me several times on x86-64 > Fedora 28. Fedora 28 is really broken right now. I have patches to fix almost everything*, but I am struggling to understand why one of them is needed. AFAICT, either __builtin_memcpy has usage changes that I missed, or there is a glibc bug here. ["compile print" is completely broken -- the __builtin_memcpy on Fedora 28 does nothing. Works fine on my Fedora 21 and 26 boxes.] Using __builtin_memmove works fine, though. [And just to state the obvious, no, the memory regions do not overlap.] Keith * "Everything" = everything except what appears to be a newly introduced GCC 8 bug that causes regressions in compile-cplus-method.exp.