From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>,
Keith Seitz <keiths@redhat.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] compile: Remove non-const reference parameters
Date: Thu, 06 Sep 2018 12:49:00 -0000 [thread overview]
Message-ID: <40fd64a28b69336a992eead1feeb4246@polymtl.ca> (raw)
In-Reply-To: <87efe6kdb3.fsf@tromey.com>
On 2018-09-06 13:42, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
>
> Simon> Good point. How is this? The only change is in enter_scope and
> its
> Simon> callers.
>
> Looks reasonable to me.
>
> Tom
Thanks, I pushed it.
Simon
next prev parent reply other threads:[~2018-09-06 12:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 16:47 Simon Marchi
2018-08-30 21:57 ` Keith Seitz
2018-08-31 14:41 ` Tom Tromey
2018-09-06 10:27 ` Simon Marchi
2018-09-06 12:43 ` Tom Tromey
2018-09-06 12:49 ` Simon Marchi [this message]
2018-09-17 6:32 ` Tom Tromey
2018-09-17 13:29 ` Keith Seitz
2018-09-17 13:52 ` [PATCH] Fix use-after-move in compile/compile-cplus-types.c Simon Marchi
2018-09-17 15:25 ` Keith Seitz
2018-09-17 17:10 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40fd64a28b69336a992eead1feeb4246@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=simon.marchi@ericsson.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox