From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67315 invoked by alias); 6 Sep 2018 12:49:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 67302 invoked by uid 89); 6 Sep 2018 12:49:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=H*u:Webmail, H*UA:Roundcube, H*u:Roundcube, Hx-languages-length:329 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Sep 2018 12:49:16 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w86CnARn005485 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 6 Sep 2018 08:49:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 026221E75F; Thu, 6 Sep 2018 08:49:10 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id CD2721E16B; Thu, 6 Sep 2018 08:49:08 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Sep 2018 12:49:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Simon Marchi , Keith Seitz , gdb-patches@sourceware.org Subject: Re: [PATCH] compile: Remove non-const reference parameters In-Reply-To: <87efe6kdb3.fsf@tromey.com> References: <1535647635-9566-1-git-send-email-simon.marchi@ericsson.com> <87lg8m1tv9.fsf@tromey.com> <921fe52d-0556-905d-88cb-6092362bcfea@ericsson.com> <87efe6kdb3.fsf@tromey.com> Message-ID: <40fd64a28b69336a992eead1feeb4246@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00097.txt.bz2 On 2018-09-06 13:42, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Good point. How is this? The only change is in enter_scope and > its > Simon> callers. > > Looks reasonable to me. > > Tom Thanks, I pushed it. Simon