Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 3/4] Return unique_xmalloc_ptr from gdbscm_safe_eval_string
Date: Tue, 17 Jul 2018 13:08:00 -0000	[thread overview]
Message-ID: <a7dd9081-cd57-42db-50db-600fecfcdd2f@redhat.com> (raw)
In-Reply-To: <20180527152009.4228-4-tom@tromey.com>

On 05/27/2018 04:20 PM, Tom Tromey wrote:

> --- a/gdb/guile/guile-internal.h
> +++ b/gdb/guile/guile-internal.h
> @@ -402,7 +402,8 @@ extern SCM gdbscm_safe_apply_1 (SCM proc, SCM arg0, SCM args,
>  
>  extern SCM gdbscm_unsafe_call_1 (SCM proc, SCM arg0);
>  
> -extern char *gdbscm_safe_eval_string (const char *string, int display_result);
> +extern gdb::unique_xmalloc_ptr<char> gdbscm_safe_eval_string
> +    (const char *string, int display_result);

Two spaces.

Otherwise OK.

Thanks,
Pedro Alves


  reply	other threads:[~2018-07-17 13:08 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-27 15:20 [RFA 0/4] some simple cleanup removal in guile Tom Tromey
2018-05-27 15:20 ` [RFA 1/4] Use std::string in ppscm_make_pp_type_error_exception Tom Tromey
2018-07-17 13:08   ` Pedro Alves
2018-05-27 15:20 ` [RFA 3/4] Return unique_xmalloc_ptr from gdbscm_safe_eval_string Tom Tromey
2018-07-17 13:08   ` Pedro Alves [this message]
2018-05-27 15:40 ` [RFA 2/4] Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr Tom Tromey
2018-07-17 13:08   ` Pedro Alves
2018-07-17 19:11     ` Tom Tromey
2018-07-18 13:29       ` [RFC] gdbscm_wrap, eliminate GDBSCM_HANDLE_GDB_EXCEPTION_WITH_CLEANUPS (Re: [RFA 2/4] Change gdbscm_exception_message_to_string to return a unique_xmalloc_ptr) Pedro Alves
2018-07-18 19:34         ` Tom Tromey
2018-07-18 22:31           ` Pedro Alves
2018-05-27 15:54 ` [RFA 4/4] Return unique_xmalloc_ptr from gdbscm_scm_to_string Tom Tromey
2018-07-17 13:09   ` Pedro Alves
2018-06-18 14:37 ` [RFA 0/4] some simple cleanup removal in guile Tom Tromey
2018-07-16 16:35   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7dd9081-cd57-42db-50db-600fecfcdd2f@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox